https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82718|0 |1 is obsolete| | Attachment #82842|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82873&action=edit Bug 15422: Correct calculation of holds ratio report See comment 1 for a detailed explanation of current calculations and needed calculations Also removes an unnecessary variable To test: 1 - Place 4 holds on a biblio with one item 2 - go to /cgi-bin/koha/circ/reserveratios.pl (Circulation->Holds ratios) 3 - Run with 'Hold ratio'=3, it says order 1, ok 4 - Run with HR=4, it says order 1, wrong 5 - Run with HR=2, it syas order 2, wrong 6 - Run with HR=.5, it syas order 4, wrong 7 - Apply patch 8 - Run with HR=3, order 1, OK 9 - Run with HR=4, item does not appear (0 to order), OK 10 - Run with HR=2, order 1, OK 11 - Run with HR=.5, order 7, OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.