[Bug 34760] New: Prevent error when logging into OPAC after conducting a search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 Bug ID: 34760 Summary: Prevent error when logging into OPAC after conducting a search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org If you have EnableOpacSearchHistory system preference enabled, Koha will either save search history to the session, or if logged in then Koha will save search history to the patron. If you do a search on the OPAC, then try to log in with SSO, an error could be thrown if the session ID wasn't saved to the cookie correctly. We should prevent this by checking if a session ID was set before trying to save search history to a logged in patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 155521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155521&action=edit Bug 34760: Confirm session ID is set to save OPAC search history to logged in user This patch confirms that a session ID has been set before trying to save search history to a logged in user on the OPAC. This depends on EnableOpacSearchHistory system preference being enabled. Apply the patch and test that you don't see an Error 500 page at any point through this plan: 1. Do an OPAC search, ensure you are not logged in 2. Confirm your search was saved to search history 3. Do another search, then log in 4. Confirm you are brought back to the search results after logging in 5. Confirm all search history from the session is visible Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155521|0 |1 is obsolete| | --- Comment #2 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 155550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155550&action=edit Bug 34760: Confirm session ID is set to save OPAC search history to logged in user This patch confirms that a session ID has been set before trying to save search history to a logged in user on the OPAC. This depends on EnableOpacSearchHistory system preference being enabled. Apply the patch and test that you don't see an Error 500 page at any point through this plan: 1. Do an OPAC search, ensure you are not logged in 2. Confirm your search was saved to search history 3. Do another search, then log in 4. Confirm you are brought back to the search results after logging in 5. Confirm all search history from the session is visible Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have mostly done regression testing here as I can't test any of the SSO methods. I also verified it that the behaviour with LoadSearchHistoryToTheFirstLoggedUser is still the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155550|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155762&action=edit Bug 34760: Confirm session ID is set to save OPAC search history to logged in user This patch confirms that a session ID has been set before trying to save search history to a logged in user on the OPAC. This depends on EnableOpacSearchHistory system preference being enabled. Apply the patch and test that you don't see an Error 500 page at any point through this plan: 1. Do an OPAC search, ensure you are not logged in 2. Confirm your search was saved to search history 3. Do another search, then log in 4. Confirm you are brought back to the search results after logging in 5. Confirm all search history from the session is visible Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.04 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34760 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org