[Bug 32544] New: borrowers.flags should not be an option in any BorrowerMandatory or BorrowerUnwanted sysprefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 Bug ID: 32544 Summary: borrowers.flags should not be an option in any BorrowerMandatory or BorrowerUnwanted sysprefs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 32535 Borrowers.flags should not be an option in the following syspref menus: PatronSelfModificationMandatoryField, PatronSelfRegistrationBorrowerMandatoryField, BorrowerMandatoryField, PatronSelfModificationBorrowerUnwantedField, PatronSelfRegistrationBorrowerUnwantedField Because permissions aren't actually set via the borrower edit screens, these checkboxes have no real purpose or effect. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 [Bug 32535] BorrowerUnwatedField syspref should not include borrowers.flags -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Summary|borrowers.flags should not |borrowers.flags should not |be an option in any |be an option in any |BorrowerMandatory or |BorrowerMandatory or |BorrowerUnwanted sysprefs |BorrowerUnwanted system | |preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144877&action=edit Bug 32544: Remove flags as option from several patron form related system preferences Because permissions aren't actually set via the patron edit screens, these checkboxes have no real purpose or effect. This removes flags from the selectable fields of the following system preferences: * PatronSelfModificationMandatoryField * PatronSelfRegistrationBorrowerMandatoryField * BorrowerMandatoryField * PatronSelfModificationBorrowerUnwantedField * PatronSelfRegistrationBorrowerUnwantedField To test: * Apply patch * Verify that the checkbox for flags can no longer be set for these preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144877|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 144880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144880&action=edit Bug 32544: Remove flags as option from several patron form related system preferences Because permissions aren't actually set via the patron edit screens, these checkboxes have no real purpose or effect. This removes flags from the selectable fields of the following system preferences: * PatronSelfModificationMandatoryField * PatronSelfRegistrationBorrowerMandatoryField * BorrowerMandatoryField * PatronSelfModificationBorrowerUnwantedField * PatronSelfRegistrationBorrowerUnwantedField To test: * Apply patch * Verify that the checkbox for flags can no longer be set for these preferences Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144880|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145852&action=edit Bug 32544: Remove flags as option from several patron form related system preferences Because permissions aren't actually set via the patron edit screens, these checkboxes have no real purpose or effect. This removes flags from the selectable fields of the following system preferences: * PatronSelfModificationMandatoryField * PatronSelfRegistrationBorrowerMandatoryField * BorrowerMandatoryField * PatronSelfModificationBorrowerUnwantedField * PatronSelfRegistrationBorrowerUnwantedField To test: * Apply patch * Verify that the checkbox for flags can no longer be set for these preferences Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another nice fix, no regressions.. Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org