[Bug 26543] New: Elasticsearch - Importing biblios with multiple items can cause incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Bug ID: 26543 Summary: Elasticsearch - Importing biblios with multiple items can cause incorrect index Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com Similar to bug 25265 we see many request for indexing a single biblio with multiple items attached when importing and matching records Additionally, the current code repeatedly generates an indexer object, we can reuse the single object to avoid creating multiple connections -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 110771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110771&action=edit Bug 26543: Refactor import code to reindex once per bib To test: 0 - Be using Elasticsearch, apply patches, reindex 1 - Add multiple items to several records in your catalog 2 - Export those records 3 - Update the items on the records in Koha to be 'damaged' 4 - Import the file exported above, matchign on biblionumber and overlaying items 5 - Perform a search to return the imported records 6 - Confirm all items have damaged correctly removed in search results 7 - Import without matching and ignoring items to confirm new records are added 8 - Search to return records and verify they are indexed (shoudl see 2 copies) 9 - Alter the barcodes of the items in koha 10 - Import the file matching on biblionumber and adding items 11 - Search tp return records, confirm the new items are indexed 12 - Export some authority records 13 - Import them without matching and confirm new records are searchable 14 - Alter the existing records, and match on AuthID, you will need to create a matching rule for this 15 - Import and match and confirm the records are searchable and reflect the change back to original values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 110772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110772&action=edit Bug 26543: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |andrew@bywatersolutions.com | |, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I got an error trying to apply this: Applying: Bug 26543: Refactor import code to reindex once per bib error: sha1 information is lacking or useless (C4/Biblio.pm). error: could not build fake ancestor Patch failed at 0001 Bug 26543: Refactor import code to reindex once per bib -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Applies now that 25265 is pushed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25265 |26557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26557 [Bug 26557] Batch import fails when incoming records contain itemnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Updating test plan. Existing step 9 led to an error as one attempted to create items based on a 952 containing an existing itemnumber: To test: 0 - Be using Elasticsearch, apply patches, reindex 1 - Add multiple items to several records in your catalog 2 - Export those records 3 - Update the items on the records in Koha to be 'damaged' 4 - Import the file exported above, matchign on biblionumber and overlaying items 5 - Perform a search to return the imported records 6 - Confirm all items have damaged correctly removed in search results 7 - Import without matching and ignoring items to confirm new records are added 8 - Search to return records and verify they are indexed (shoudl see 2 copies) 9 - Alter exported records to remove itemnumber and barcode 10 - Import the file matching on biblionumber and adding items 11 - Search tp return records, confirm the new items are indexed 12 - Export some authority records 13 - Import them without matching and confirm new records are searchable 14 - Alter the existing records, and match on AuthID, you will need to create a matching rule for this 15 - Import and match and confirm the records are searchable and reflect the change back to original values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Failing on step 13. New authorities are created but don't come up in searches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26903 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 [Bug 26903] Imported authorities not added to ES indices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- See blocking bug, 26903. Turns out the behavior I ran into happens on master without this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Bug 26543 depends on bug 26557, which changed state. Bug 26557 Summary: Batch import fails when incoming records contain itemnumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26557 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Bug 26543 depends on bug 26903, which changed state. Bug 26903 Summary: Authority records not being indexed in Elasticsearch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|BLOCKED |RESOLVED --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 30822 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org