[Bug 15975] New: Add Owning Library Column to Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Bug ID: 15975 Summary: Add Owning Library Column to Checkouts Change sponsored?: Seeking cosponsors Product: Koha Version: master Hardware: All URL: http://devs.bywatersolutions.com/projects/add-owning-l ibrary-column-checkouts/ OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Work to do: Include owning library column on the list of checkouts for patrons. Pages needing enhancement: cgi-bin/koha/circ/circulation.pl cgi-bin/koha/members/moremember.pl Seeking Co Sponsors : http://devs.bywatersolutions.com/projects/add-owning-library-column-checkout... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jweaver@bywatersolutions.co | |m Status|NEW |ASSIGNED Change sponsored?|Seeking cosponsors |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver@bywatersolutions.co |nick@bywatersolutions.com |m | CC| |amy@bywatersolutions.com, | |nick@bywatersolutions.com, | |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 53399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53399&action=edit Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Owning library' column 3 - Apply patch 4 - Note there IS an 'Owning library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, I think this should be 'home library' to fit with our usual terminology, what do you think? It's what we use on the detail page for example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #2)
Hi Nick, I think this should be 'home library' to fit with our usual terminology
Agreed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53399|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 53550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53550&action=edit Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Owning library' column 3 - Apply patch 4 - Note there IS an 'Owning library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 53551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53551&action=edit Datatable error with patch applied With patch applied, I get a datatable warning whilt checking out: "Requested unknown parameter 'homebranch' for row 0, column 7". See screenshot. Without patch, error does not appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53550|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 53566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53566&action=edit Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Owning library' column 3 - Apply patch 4 - Note there IS an 'Owning library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/) Works as expected (after clearing browser cache) Signed-off-by: Marc <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Trivial patch --- Comment #7 from Marc Véron <veron@veron.ch> --- Re-tested with browser cache cleared... Sorry for the noise :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tiny request: please adapt commit message to new column name! I am changing the bug title too as this is used for the release notes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Owning Library Column |Add Home Library Column to |to Checkouts |Checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53566|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 53580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53580&action=edit Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Home library' column 3 - Apply patch 4 - Note there IS an 'Home library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/) Works as expected (after clearing browser cache). Commit message amended (as of comment #7) Signed-off-by: Marc <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, can you check the additional time added by this new join on a relatively big table (100 checkouts displayed)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- With this patch there is a small display error in the table of checkouts: the new column leaves a gap at the end of the last grey line holding the totals and renewal due date. This happens on the checkouts and the details tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #10)
Nick, can you check the additional time added by this new join on a relatively big table (100 checkouts displayed)?
I don't see a real difference at 105 checkouts BEFORE Table in ms (Page in Seconds) 1123 (2.01) 1136 (3.23) 1213 (3.09) 1231 (3.17) 1137 (3.92) 1128 (3.04) 1177 (3.04) 1969 (4.87) 1146 (3.12) 1126 (3.33) AFTER Table in ms (Page in Seconds) 1088 (3.29) 1105 (3.02) 1127 (2.93) 1154 (3.14) 1158 (3.29) 1189 (3.32) 1121 (3.09) 1210 (3.11) 1224 (3.66) 1214 (3.67) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #11)
With this patch there is a small display error in the table of checkouts: the new column leaves a gap at the end of the last grey line holding the totals and renewal due date. This happens on the checkouts and the details tab.
Can you give me a screen shot? I can't recreate this one - once I restart plack and clear cache it looks okay on my end -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55583&action=edit Bug 15975 (QA Followup) Fix colspan for footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53580|0 |1 is obsolete| | Attachment #55583|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55655&action=edit [PASSED QA] Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Home library' column 3 - Apply patch 4 - Note there IS an 'Home library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/) Works as expected (after clearing browser cache). Commit message amended (as of comment #7) Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55656&action=edit [PASSED QA] Bug 15975 (QA Followup) Fix colspan for footer Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org