[Bug 30436] New: Convert article requests tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Bug ID: 30436 Summary: Convert article requests tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the article requests template with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 132870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132870&action=edit Bug 30436: Convert article requests tabs to Bootstrap This patch converts the jQuery tabs on the article requests page to Bootstrap. To test you should have the "ArticleRequests" system preference enabled. If necessary, create some article requests and mark some "Pending," some "Processing," and leave some new. - Apply the patch and go to Circulation -> Article requests. - The page should show three tabs: New, Pending, and Processing. - The tabs should look correct and work correctly. - The DataTables under each tab should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Failed QA --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Hi Owen ! After I applied the patch, the 'Select all' and 'Clear all' options don't work any more in the 'Pending' and 'Processing' tab. Everything else is ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132870|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 132928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132928&action=edit Bug 30436: Convert article requests tabs to Bootstrap This patch converts the jQuery tabs on the article requests page to Bootstrap. To test you should have the "ArticleRequests" system preference enabled. If necessary, create some article requests and mark some "Pending," some "Processing," and leave some new. - Apply the patch and go to Circulation -> Article requests. - The page should show three tabs: New, Pending, and Processing. - The tabs should look correct and work correctly. - The DataTables under each tab should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132928|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132933&action=edit Bug 30436: Convert article requests tabs to Bootstrap This patch converts the jQuery tabs on the article requests page to Bootstrap. To test you should have the "ArticleRequests" system preference enabled. If necessary, create some article requests and mark some "Pending," some "Processing," and leave some new. - Apply the patch and go to Circulation -> Article requests. - The page should show three tabs: New, Pending, and Processing. - The tabs should look correct and work correctly. - The DataTables under each tab should work correctly. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Thank you Owen for the quick rebase, everything works fine now ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, with the patch there's a minor style issue, spacing between the library dropdown and the tabs is too little: https://snipboard.io/8eNKCI.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 [Bug 30466] Convert serials pages tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Tomás Cohen Arazi from comment #6)
Hi, with the patch there's a minor style issue, spacing between the library dropdown and the tabs is too little:
Fixed in Bug 30466. I've added it as a dependency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133479&action=edit Bug 30436: Convert article requests tabs to Bootstrap This patch converts the jQuery tabs on the article requests page to Bootstrap. To test you should have the "ArticleRequests" system preference enabled. If necessary, create some article requests and mark some "Pending," some "Processing," and leave some new. - Apply the patch and go to Circulation -> Article requests. - The page should show three tabs: New, Pending, and Processing. - The tabs should look correct and work correctly. - The DataTables under each tab should work correctly. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- All works correctly using the scss generated from bug 30466 solved the (minor) visual glitch. Well done! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Bug 30436 depends on bug 30466, which changed state. Bug 30466 Summary: Convert serials pages tabs to Bootstrap https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org