[Bug 39750] New: Wrong transfer breaking check in when using branch transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Bug ID: 39750 Summary: Wrong transfer breaking check in when using branch transfer limits Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1 - Enable UseBranchTransferLimits based on 'Collection code' 2 - Disable transfers for FIC from: CPL -> FFL CPL -> IPT FFL -> CPL FFL -> IPT IPT -> CPL IPT -> FFL 3 - Set library to IPT 4 - Checkin an FFL item 5 - It generates a transfer home 6 - Set library to CPL 7 - Check the item in 8 - 500 error, and in logs: ==> /var/log/koha/kohadev/plack-error.log <== Exception 'Koha::Exceptions::Item::Transfer::Limit' thrown 'Transfer not allowed' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 181547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181547&action=edit Bug 39750: Ignore limits when updating WrongTransfer This patch ignores limits when updating a wrong transfer to ensure we can return a book home when checked in at the wrong branch To test: 1 - Enable UseBranchTransferLimits based on 'Collection code' 2 - Disable transfers for FIC from: CPL -> FFL CPL -> IPT FFL -> CPL FFL -> IPT IPT -> CPL IPT -> FFL 3 - Set library to IPT 4 - Checkin an FFL item 5 - It generates a transfer home 6 - Set library to CPL 7 - Check the item in 8 - 500 error, and in logs: ==> /var/log/koha/kohadev/plack-error.log <== Exception 'Koha::Exceptions::Item::Transfer::Limit' thrown 'Transfer not allowed' 9 - Apply patch, restart all 10 - Check item in again 11 - Success! Transfer updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181547|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 181557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181557&action=edit Bug 39750: Ignore limits when updating WrongTransfer This patch ignores limits when updating a wrong transfer to ensure we can return a book home when checked in at the wrong branch To test: 1 - Enable UseBranchTransferLimits based on 'Collection code' 2 - Disable transfers for FIC from: CPL -> FFL CPL -> IPT FFL -> CPL FFL -> IPT IPT -> CPL IPT -> FFL 3 - Set library to IPT 4 - Checkin an FFL item 5 - It generates a transfer home 6 - Set library to CPL 7 - Check the item in 8 - 500 error, and in logs: ==> /var/log/koha/kohadev/plack-error.log <== Exception 'Koha::Exceptions::Item::Transfer::Limit' thrown 'Transfer not allowed' 9 - Apply patch, restart all 10 - Check item in again 11 - Success! Transfer updated Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181557|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181575&action=edit Bug 39750: Ignore limits when updating WrongTransfer This patch ignores limits when updating a wrong transfer to ensure we can return a book home when checked in at the wrong branch To test: 1 - Enable UseBranchTransferLimits based on 'Collection code' 2 - Disable transfers for FIC from: CPL -> FFL CPL -> IPT FFL -> CPL FFL -> IPT IPT -> CPL IPT -> FFL 3 - Set library to IPT 4 - Checkin an FFL item 5 - It generates a transfer home 6 - Set library to CPL 7 - Check the item in 8 - 500 error, and in logs: ==> /var/log/koha/kohadev/plack-error.log <== Exception 'Koha::Exceptions::Item::Transfer::Limit' thrown 'Transfer not allowed' 9 - Apply patch, restart all 10 - Check item in again 11 - Success! Transfer updated Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong transfer breaking |Wrong transfer breaking |check in when using branch |check in when using library |transfer limits |transfer limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #6 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflicts with 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 [Bug 40771] Wrong transfer breaking check in for holds when using library transfer limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org