[Bug 8271] New: teach SIPServer to set its own lib path
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 Priority: P5 - low Change sponsored?: --- Bug ID: 8271 CC: colin.campbell@ptfs-europe.com Assignee: koha-bugs@lists.koha-community.org Summary: teach SIPServer to set its own lib path Severity: enhancement Classification: Unclassified OS: All Reporter: colin.campbell@ptfs-europe.com Hardware: All Status: NEW Version: master Component: SIP2 Product: Koha The SIPserver uses a libpath different from the rest of Koha its passed in the upscript using -I. having cd'd to the C4/SIP directory. Perl has a perfectly good way to manage this rather than relying on -I being set correctly in a calling script. Using it may remove a barrier to setting up and debugging sip configurations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 10361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10361&action=edit Proposed Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Corrected status of this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10361|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10573&action=edit Bug 8271 teach SIPServer.pm to set its own lib path SIPServer.pm requires that C4/SIP is added to its lib path This has been done by passing this directory to it via -I. By using FindBin it can set the path for itself correctly. This will also work if the C4/SIP directory tree is moved to a non-standard location Removed the now redundant -I. from sip_run.sh Added a variable to sip_run.sh for the koha tree to highlight a problem with the script if you have multiple directories in the PERL5LIB environment variable Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: small change, passes QA without any problem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- I haven't tested this patch, but I trust Colin enough to push it (chris_c, not sure it should be ported to 3.8, but maybe) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org