[Bug 16890] New: TestBuilder always generate datetime for dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Bug ID: 16890 Summary: TestBuilder always generate datetime for dates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: gmcharlt@gmail.com TestBuilder should not generate datetime for date columns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53246&action=edit Bug 16890: Make TestBuilder generate date for date columns (and not datetime) TestBuilder should not generate datetime for date columns, but only for datetime and timestamp columns. Test plan: Make sure the change in t/db_dependent/TestBuilder.t are consistent. Before this patch, 1 of the 2 tests should fail. After this patch applied, they both should pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891 [Bug 16891] Move MoveMemberToDeleted to Koha::Patron->move_to_deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53246|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 53298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53298&action=edit [SIGNED-OFF] Bug 16890: Make TestBuilder generate date for date columns (and not datetime) TestBuilder should not generate datetime for date columns, but only for datetime and timestamp columns. Test plan: Make sure the change in t/db_dependent/TestBuilder.t are consistent. Before this patch, 1 of the 2 tests should fail. After this patch applied, they both should pass. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16907 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 [Bug 16907] Move DelMember and HandleDelBorrower to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53298|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53353&action=edit [PASSED QA] Bug 16890: Make TestBuilder generate date for date columns (and not datetime) TestBuilder should not generate datetime for date columns, but only for datetime and timestamp columns. Test plan: Make sure the change in t/db_dependent/TestBuilder.t are consistent. Before this patch, 1 of the 2 tests should fail. After this patch applied, they both should pass. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org