[Bug 42607] New: Holds queue: Remove intermediate filter page now that results are API-driven
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42607 Bug ID: 42607 Summary: Holds queue: Remove intermediate filter page now that results are API-driven Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Depends on: 42503 Now that the holds queue page is fully API-driven with server-side pagination, filtering, and sorting (bug 42503), the intermediate step where the user must choose a library filter before seeing results is unnecessary. The table can load immediately with all results (paginated) and the library filter can be a column filter or a dropdown above the table, like other API-driven pages. Additionally, the breadcrumbs still show a 'Results' level that no longer makes sense with the single-page approach. Changes needed: - Remove the initial filter form / two-step flow - Load the holds queue table directly on page load - Move the library filter to a table filter control - Remove 'Results' from breadcrumbs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 [Bug 42503] Render the holds queue using the REST API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42607 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |andrew@bywatersolutions.com | |, nick@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42607 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42607 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199154&action=edit Bug 42607: Remove intermediate filter page from holds queue Now that the holds queue is fully API-driven with server-side pagination (bug 42503), the intermediate step requiring users to choose filters before seeing results is unnecessary. This patch: - Loads the holds queue table immediately on page load - Moves filters permanently to the sidebar - Removes the 'Results' breadcrumb level - Removes the run_report parameter from the controller - Changes the submit button label from 'Submit' to 'Filter' The UseHoldsQueueFilterOptions system preference is no longer relevant for this page's flow. Test plan: 1. Apply all patches for bug 42503 and this patch 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev 3. Navigate to Circulation > Holds queue => SUCCESS: Table loads immediately with all holds queue items => SUCCESS: Filters are in the sidebar => SUCCESS: Breadcrumbs show: Circulation > Holds queue (no 'Results') 4. Use the sidebar filters to narrow results => SUCCESS: Table redraws with filtered results 5. Click 'Clear' => SUCCESS: Filters reset and table shows all items 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42607 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41788 Status|Needs Signoff |In Discussion --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I wasn't aware of the discussion that happened on bug 41788 around the area. So I'm leaving this as 'In discussion' in case folks reconsider how they want the page to work now that speed/system load is no longer an issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42607 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42607 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen@gmail.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42607 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #3 from Donna <bwsdonna@gmail.com> --- If I am at a multi-site library system, when I click the Holds Queue button - does it no longer limit to just the library I am logged in to? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org