[Bug 23676] New: Elasticsearch - 0 is not a valid boolean for suppress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Bug ID: 23676 Summary: Elasticsearch - 0 is not a valid boolean for suppress Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com To recreate: 1 - Enable ES 2 - Enable OpacSuppression 3 - Suppress a bib in staff client Edit 942n to be 1 4 - Search the opac for anything 5 - Tail the plack logs and note a deprecation warning In a production system these add up fast and can fill the disk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93161&action=edit Bug 23676: Use 'false' for opac suppression To test: 1 - Enable ES 2 - Enable OpacSuppression 3 - Suppress a bib in staff client Edit 942n to be 1 4 - Search the opac for anything 5 - Tail the plack logs and note a deprecation warning 6 - Apply patch 7 - Restart all the things 8 - Repeat search on opac 9 - No error/warn in logs 10 - Record is correctly suppressed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23470 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #2 from Michal Denar <black23@gmail.com> --- Hello Nick, can you rebase this patch on master? CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23676: Use 'false' for opac suppression Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi --- Comment #3 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- What log is where the warning goes and which version of elasticsearch do you use? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune@bulac.fr --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Michal Denar from comment #2)
Hello Nick, can you rebase this patch on master?
CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23676: Use 'false' for opac suppression
Thank you.
Same as Michal :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93161|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95572&action=edit Bug 23676: Use 'false' for opac suppression To test: 1 - Enable ES 2 - Enable OpacSuppression 3 - Suppress a bib in staff client Edit 942n to be 1 4 - Search the opac for anything 5 - Tail the plack logs and note a deprecation warning 6 - Apply patch 7 - Restart all the things 8 - Repeat search on opac 9 - No error/warn in logs 10 - Record is correctly suppressed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Joonas Kylmälä from comment #3)
What log is where the warning goes and which version of elasticsearch do you use?
plack-error.log This is in ES 5.x, I think it breaks in 6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95572|0 |1 is obsolete| | --- Comment #7 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 96695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96695&action=edit Bug 23676: Use 'false' for opac suppression To test: 1 - Enable ES 2 - Enable OpacSuppression 3 - Suppress a bib in staff client Edit 942n to be 1 4 - Search the opac for anything 5 - Tail the plack logs and note a deprecation warning 6 - Apply patch 7 - Restart all the things 8 - Repeat search on opac 9 - No error/warn in logs 10 - Record is correctly suppressed Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu --- Comment #8 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Patch seemed to work as expected. Test results: 1 - Enabled ES 2 - Enabled OpacSuppression 3 - Suppressed a bib in staff client Edit 942n to be 1 4 - Searched the opac for keywords related to suppressed record 5 - Tail the plack logs and note a deprecation warning >> entered command koha-plack-err and watched for warnings; noted deprecation warnings when searching 6 - Applied patch 7 - Restart all the things >> restart_all, updatedatabase, reindex ES 8 - Repeated search on opac 9 - No error/warn in logs >> watched koha-plack-err again and no new deprecation warnings appeared after multiple searches 10 - Record is correctly suppressed >> repeated search in staff client and verified opac suppression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am using 6.8.3 and OpacSuppression breaks the OPAC search, nothing in the log. This patch fixes the problem! Also it correctly hides the record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96695|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97220&action=edit Bug 23676: Use 'false' for opac suppression To test: 1 - Enable ES 2 - Enable OpacSuppression 3 - Suppress a bib in staff client Edit 942n to be 1 4 - Search the opac for anything 5 - Tail the plack logs and note a deprecation warning 6 - Apply patch 7 - Restart all the things 8 - Repeat search on opac 9 - No error/warn in logs 10 - Record is correctly suppressed Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 23470 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy@bywatersolutions.com --- Comment #13 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03 released in|19.05.08 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- this patchset has been reverted from 19.05.x as it has been problematic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31061 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31061 [Bug 31061] OPACSuppress does not work properly with Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org