[Bug 23975] New: Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Bug ID: 23975 Summary: Add ability to search and install plugins from GitHub Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 95067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95067&action=edit Bug 23975: [PoC] Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is an awesome PoC :) Wish list wise I'd love to see. 1) Metadata that's currently embedded inside the plugins main class pulled out into a json (or yaml) file in the repository as a standard so we could read that and get things like supported versions etc into this. 2) Perhaps some 'Changelog.md' or 'Readme.md' support somehow at some point 3) Support for gitlab added. But, this is a great first proof we can refine :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Going further with the moving metadata outside of the file, this could allow us to adopt signed manifest approach and make our plugins that bit more secure and reliable. Let's give this a real push for 20.05 and give the best plugins another bug lift in that release. That should give us ample time to work it out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #2)
This is an awesome PoC :)
Wish list wise I'd love to see.
1) Metadata that's currently embedded inside the plugins main class pulled out into a json (or yaml) file in the repository as a standard so we could read that and get things like supported versions etc into this. 2) Perhaps some 'Changelog.md' or 'Readme.md' support somehow at some point 3) Support for gitlab added.
But, this is a great first proof we can refine :)
And Gitlab support :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Lets get this one moving again.. lots of great enhancements suggested, but lets start with this bug and build a tree of enhancements later. So.. I think all that's missing is the 'install' action.. I'll take a look -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24631 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 [Bug 24631] Plugin metadata should be outside the main class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24632 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 [Bug 24632] Plugins should support simple signing for security/varifiability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633 [Bug 24633] Add support for gitlab searching of plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24634 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24634 [Bug 24634] Support display of changelog files for plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24635 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24635 [Bug 24635] Support display of readme files for plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98757&action=edit Bug 23975: Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98758&action=edit Bug 23975: Add 'Install' support for github results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95067|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- The search worked fine! Should I be able to install a plugin yet? I can install plugins the standard way. This is the start of the error message I got clicking the Install button from the search results: Can't locate object method "save_to" via package "Mojo::Message::Response" at /kohadevbox/koha/plugins/plugins-upload.pl line 78 in (eval) at /kohadevbox/koha/plugins/plugins-upload.pl line 78 75: if ( $uploadlocation ) { 76: my $ua = Mojo::UserAgent->new(max_redirects => 5); 77: my $tx = $ua->get($uploadlocation); 78: $tx->result->save_to($tempfile); 79: } else { 80: $errors{'EMPTYUPLOAD'} = 1 unless ( length($uploadfile) > 0 ); 81: } in CGI::Compile::ROOT::kohadevbox_koha_plugins_plugins_2dupload_2epl::__ANON__ at /kohadevbox/koha/plugins/plugins-upload.pl line 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ah, 'save_to' was added to mojo in version 8.02. I'll have a look at how we can support this without using that call. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98757|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98791&action=edit Bug 23975: Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98758|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98792&action=edit Bug 23975: Add 'Install' support for github results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98793&action=edit Bug 23975: (follow-up) Don't rely on save_to being present The `save_to` shortcut method was introduced to Mojolicious in version 8.02 but we still support 7.21 as our minimum dependancy and as such we cannot yet use it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The followup should get Install working more consistently now.. thanks for testing David. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98791|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 98800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98800&action=edit Bug 23975: Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98792|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 98801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98801&action=edit Bug 23975: Add 'Install' support for github results Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98793|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 98802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98802&action=edit Bug 23975: (follow-up) Don't rely on save_to being present The `save_to` shortcut method was introduced to Mojolicious in version 8.02 but we still support 7.21 as our minimum dependancy and as such we cannot yet use it. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #17 from David Nind <david@davidnind.com> --- You may also need to add this to your Apache configuration (in the staff interface section - this folder location works for koha-testing-docker): <Directory "/var/lib/koha/kohadev/plugins"> Require all granted </Directory> Alias /plugin "/var/lib/koha/kohadev/plugins/" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98800|0 |1 is obsolete| | Attachment #98801|0 |1 is obsolete| | Attachment #98802|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 98813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98813&action=edit Bug 23975: Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 98814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98814&action=edit Bug 23975: Add 'Install' support for github results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 98815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98815&action=edit Bug 23975: (follow-up) Don't rely on save_to being present The `save_to` shortcut method was introduced to Mojolicious in version 8.02 but we still support 7.21 as our minimum dependancy and as such we cannot yet use it. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- My feeling is that we should maintain a list of "accepted"/"validated" plugins, and so have a WS serving (on a Koha community server) that list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #21)
My feeling is that we should maintain a list of "accepted"/"validated" plugins, and so have a WS serving (on a Koha community server) that list.
I did initially think the same and intended to write such a service.. however I have come around to this approach as it reduces the need build, host and maintain another system, not to mention maintaining the data. I have added followup bugs that request we add signatures to plugin releases and a way from inside Koha itself to validate those. Once we have those I think we pretty much have what you are suggesting.. we can update the default config we ship to only include a pointer to the community gitlab and as we as a community deem a plugin to have reached a level of maturity we are happy with we can suggest an adoption of it into our gitlab and thus sign subsequent releases. Hope that makes sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> ---
Once we have those I think we pretty much have what you are suggesting.. we can update the default config we ship to only include a pointer to the community gitlab and as we as a community deem a plugin to have reached a level of maturity we are happy with we can suggest an adoption of it into our gitlab and thus sign subsequent releases.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99958&action=edit Bug 23975: (QA follow-up) Fix stylingof install buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99958|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98813|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98814|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98815|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 99970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99970&action=edit Bug 23975: Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 99971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99971&action=edit Bug 23975: Add 'Install' support for github results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 99972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99972&action=edit Bug 23975: (follow-up) Don't rely on save_to being present The `save_to` shortcut method was introduced to Mojolicious in version 8.02 but we still support 7.21 as our minimum dependancy and as such we cannot yet use it. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 99973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99973&action=edit Bug 23975: (QA follow-up) Fix stylingof install buttons Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 99974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99974&action=edit Bug 23975: (QA follow-up) Search button style and functionality This patch makes the search form button match the other buttons style, and also adds the submit() action on click. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 99975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99975&action=edit Bug 23975: (QA follow-up) Add missing TT filters Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am sorry but I have concerns about this patch. Feel free to ignore them. To me this feature is not ready as it. With those patches, the default will be to search on theke and bws github repo. Nothing says that the plugins are fetched from "outside". Did anyone review those plugins? Why only those 2 companies? What about others (ptfs-e, biblibre, inlibro, etc)? What if a plugin that have security issues is pushed to those repos? When are you going to work on follow-up bugs? Is the plan to have them ready for 20.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I intend to start working on those bugs, and encourage Kyle and Tomas to help very soon.. I've left the default config in on master for now so that developers get exposed to the feature whilst we're in development, but I intend to drop those as defaults just before release... hopefully to have been replaced with a default of the community gitlab with hopefully at least a few reviewed plugins within it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch makes public release notes| |plugins discoverable from | |within Koha itself via a | |search box at the top of | |the plugin management page. | | | |One can search for plugins | |and install them directly | |from their source. | | | |WARNING: Plugins are not | |yet verified by the | |community, use at your own | |risk | | | |RELEASE NOTE: During | |development, ByWater | |Solutions, Theke Solutions | |and PTFS-Europe | |repositories have all been | |added as example search | |paths. The intention is to | |remove these prior to | |release and encourage | |companies to add their own | |instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #34 from Joy Nelson <joy@bywatersolutions.com> --- new feature not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #35 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #31)
I am sorry but I have concerns about this patch. Feel free to ignore them.
To me this feature is not ready as it. With those patches, the default will be to search on theke and bws github repo. Nothing says that the plugins are fetched from "outside". Did anyone review those plugins? Why only those 2 companies? What about others (ptfs-e, biblibre, inlibro, etc)? What if a plugin that have security issues is pushed to those repos?
I have those same concerns. At the very least, there should be transparency about where the plugins are being fetched from.
When are you going to work on follow-up bugs? Is the plan to have them ready for 20.05?
I've done the plugin signing work on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632, but I only did it for manually uploaded plugins. I only noticed this bug's functionality as I was wrapping up my initial work. I'll have to revisit it... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Plugin architecture |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch makes public |This patch makes public release notes|plugins discoverable from |plugins discoverable from |within Koha itself via a |within Koha itself via a |search box at the top of |search box at the top of |the plugin management page. |the plugin management page. | | |One can search for plugins |One can search for plugins |and install them directly |and install them directly |from their source. |from their source. | | |WARNING: Plugins are not |WARNING: Plugins are not |yet verified by the |yet verified by the |community, use at your own |community, use at your own |risk |risk. The feature is | |**disabled** by default; to |RELEASE NOTE: During |enable it an administrator |development, ByWater |must uncomment, or add new |Solutions, Theke Solutions |lines to, the relevant |and PTFS-Europe |configuration lines inside |repositories have all been |the `plugin_repos` config |added as example search |block within koha-conf.xml. |paths. The intention is to | |remove these prior to | |release and encourage | |companies to add their own | |instead. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #36 from David Cook <dcook@prosentient.com.au> --- I'm noticing that the plugin_repos isn't appearing in /etc/koha/sites/kohadev/koha-conf.xml in koha-testing-docker. I'm guessing that it just hasn't been added into a Docker image yet? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #37 from David Cook <dcook@prosentient.com.au> --- Trying this out for the first time and I really like the idea of fetching plugins from a repository and installing them, but I don't like how you have to know exactly what you're looking for. I think it would be nicer if you could get a list of all available plugins. Hmm searching for '%' or 'koha-plugin' is generating errors. I'll create a new issue for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #38 from David Cook <dcook@prosentient.com.au> --- Wow... looks like it may have been due to rate limiting. You're supposed to get 60 requests per hour. I don't think that I've done that many... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #39 from David Cook <dcook@prosentient.com.au> --- Interestingly, I can do lots of queries to the search API... https://api.github.com/search/repositories?q=coverflow+user:bywatersolutions... But I am blocked for this: https://api.github.com/repos/bywatersolutions/koha-plugin-coverflow/releases... I was just messing around for 5 minutes. This seems like it would never be feasible for production? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 [Bug 25952] Github search for plugin throwing errors for % and koha-plugin search terms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25672 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25952 | --- Comment #40 from David Cook <dcook@prosentient.com.au> --- I'll stop spamming in a moment... I'm actually thinking a bit about making a plugin that manages plugins. I was inspired by the "Game Package Registry for Unity". It's a package you can add to the Unity IDE, and it lets you then import all Google packages into Unity IDE without having to manually find, download, and import into Unity IDE... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 [Bug 25952] Github search for plugin throwing errors due to API rate limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 [Bug 25952] Github search for plugin throwing errors due to API rate limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 [Bug 26751] Fatal exception if only one repo defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Vihaan Gupta <ujjwalguptax202@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ujjwalguptax202@gmail.com --- Comment #41 from Vihaan Gupta <ujjwalguptax202@gmail.com> --- i am not able to find usekohaplugin in koha version 20.05 in system perfrences can any one tell me where to i have enable in new koha version????? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Vihaan Gupta from comment #41)
i am not able to find usekohaplugin in koha version 20.05 in system perfrences can any one tell me where to i have enable in new koha version?????
That system preference was removed by bug 20415 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Manos PETRIDIS <egpetridis@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis@yahoo.com --- Comment #43 from Manos PETRIDIS <egpetridis@yahoo.com> --- Is the "new block for plugin_repos" described somewhere? I see that the the system preference for plugins has been removed, but existing koha-conf.xmls have not been updated with the new block, even in commented form. Where is one to find it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Manos PETRIDIS from comment #43)
Is the "new block for plugin_repos" described somewhere? I see that the the system preference for plugins has been removed, but existing koha-conf.xmls have not been updated with the new block, even in commented form. Where is one to find it?
Hi Manos, it's in the source: https://git.koha-community.org/Koha-community/Koha/src/commit/7bddfeb412e427... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- CC| |paul.derscheid@lmscloud.de Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #45 from Paul Derscheid <paul.derscheid@lmscloud.de> --- The patches don't apply on the current master branch anymore. Lots of merge conflicts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #46 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Paul Derscheid from comment #45)
The patches don't apply on the current master branch anymore. Lots of merge conflicts.
This is already in the codebase since 2020. Best regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33776 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 [Bug 33776] Add inLibro in default plugin repositories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41720 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41720 [Bug 41720] Plugin metadata should be outside the main class -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org