[Bug 40727] New: Minor styling bug in print/email receipt pop-up menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Bug ID: 40727 Summary: Minor styling bug in print/email receipt pop-up menu Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org I was documenting Bug 33473 and noticed a very tiny bug in the styling of the pop-up menu options to print or send a receipt by email. To recreate: 1. Go to a patron's account 2. Make sure they have an email address in their account 3. Go to their Accounting tab 4. Create a manual invoice 5. Pay the fee 6. Go to the Transactions tab and click the Receipt button --> There should be two options: Print and Email --> Note that the options are slightly misaligned (the Print is slightly more to the left) 7. Hover the mouse cursor over one option and then the next --> The background for the Email option goes over the edge of the pop-up menu on the right -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33473 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33473 [Bug 33473] Allow to send email receipts for payments/writeoff manually instead of automatically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39448 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Possibly caused by bug 39448 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39448 [Bug 39448] Layout improvement for search filter administration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Assignee|oleonard@myacpl.org |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186170&action=edit Bug 40727: Fix minor styling bug To test: 1. Go to a patron's account 2. Make sure they have an email address in their account 3. Go to their Accounting tab 4. Create a manual invoice 5. Pay the fee 6. Go to the Transactions tab and click the Receipt button --> There should be two options: Print and Email --> Note that the options are slightly misaligned (the Print is slightly more to the left) 7. Hover the mouse cursor over one option and then the next --> The background for the Email option goes over the edge of the pop-up menu on the right 8. Apply the patch. Do a yarn build and then restart_all. Next clear the cache in your local browser and refresh the page. 9. Repeat steps 6 & 7. Email is now properly aligned and when you hover over it the button no longer overflows. 10. Sign off -- have a great day :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I think a simpler solution would be to remove these lines from staff-global.scss, starting at line 2220: td { &.actions { white-space: nowrap; a, button { display: inline-block; - margin-left: .3rem; - - - &:first-child { - margin-left: 0; - } } } It doesn't appear to be necessary for us to add the left margin manually. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39448 added minor spacing to the action buttons. Without this spacing, the layout can look a bit tight—though that might come down to personal preference. My patch just ensures that "Email" isn’t affected by the spacing applied to the action buttons. I'm open to whatever might work best though -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186170|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 186263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186263&action=edit Bug 40727: Fix minor styling bug To test: 1. Go to a patron's account 2. Make sure they have an email address in their account 3. Go to their Accounting tab 4. Create a manual invoice 5. Pay the fee 6. Go to the Transactions tab and click the Receipt button --> There should be two options: Print and Email --> Note that the options are slightly misaligned (the Print is slightly more to the left) 7. Hover the mouse cursor over one option and then the next --> The background for the Email option goes over the edge of the pop-up menu on the right 8. Apply the patch. Do a yarn build and then restart_all. Next clear the cache in your local browser and refresh the page. 9. Repeat steps 6 & 7. Email is now properly aligned and when you hover over it the button no longer overflows. 10. Sign off -- have a great day :D Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The fix works. I don't have an opinions as to how the change was made, but it does fix the problem that I noticed. Thank you Laura! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |oleonard@myacpl.org |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Bug 40727 depends on bug 33473, which changed state. Bug 33473 Summary: Allow to send email receipts for payments/writeoff manually instead of automatically https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33473 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191492&action=edit Bug 40727: (alternate) Remove unnecessary .actions CSS This patch takes an alternate approach of removing some CSS which isn't strictly necessary. I think there was a time when the Bootstrap buttons didn't come with their own margins and we needed to add it manually. This change will slightly affect the margins of any buttons inside a td.actions, but the default margin looks fine to me. Examples: - Administration -> Patron categories - Tools -> Notices and slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Laura's patch isn't incorrect, but I think it's better to remove CSS where we have the option. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191492|0 |1 is obsolete| | --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 191498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191498&action=edit Bug 40727: (alternate) Remove unnecessary .actions CSS This patch takes an alternate approach of removing some CSS which isn't strictly necessary. I think there was a time when the Bootstrap buttons didn't come with their own margins and we needed to add it manually. This change will slightly affect the margins of any buttons inside a td.actions, but the default margin looks fine to me. Examples: - Administration -> Patron categories - Tools -> Notices and slips Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- idem as my previous comment :) The alternate fix works as well. I'm not knowledgeable enough to have an opinion as to how it is fixed. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Applying patches fails on merge conflict. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186263|0 |1 is obsolete| | Attachment #191498|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192613&action=edit Bug 40727: (alternate) Remove unnecessary .actions CSS This patch takes an alternate approach of removing some CSS which isn't strictly necessary. I think there was a time when the Bootstrap buttons didn't come with their own margins and we needed to add it manually. This change will slightly affect the margins of any buttons inside a td.actions, but the default margin looks fine to me. Examples: - Administration -> Patron categories - Tools -> Notices and slips Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192613|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192614&action=edit Bug 40727: (alternate) Remove unnecessary .actions CSS This patch takes an alternate approach of removing some CSS which isn't strictly necessary. I think there was a time when the Bootstrap buttons didn't come with their own margins and we needed to add it manually. This change will slightly affect the margins of any buttons inside a td.actions, but the default margin looks fine to me. Examples: - Administration -> Patron categories - Tools -> Notices and slips Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192614|0 |1 is obsolete| | --- Comment #14 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 192711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192711&action=edit Bug 40727: (alternate) Remove unnecessary .actions CSS This patch takes an alternate approach of removing some CSS which isn't strictly necessary. I think there was a time when the Bootstrap buttons didn't come with their own margins and we needed to add it manually. This change will slightly affect the margins of any buttons inside a td.actions, but the default margin looks fine to me. Examples: - Administration -> Patron categories - Tools -> Notices and slips Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 --- Comment #15 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Works as described. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|oleonard@myacpl.org |emmi.takkinen@koha-suomi.fi Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Upgrading Emmi's signoff to a QA. Code all makes sense to me in review and I'm not seeing any regressions myself either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 --- Comment #18 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40727 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #19 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Enhancement - not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org