[Bug 6193] New: Use memcached cache koha-conf.xml configuration variables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Bug #: 6193 Summary: Use memcached cache koha-conf.xml configuration variables Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: tomascohen@gmail.com QAContact: koha-bugs@lists.koha-community.org Using memcached to avoid parsing the koha-conf.xml each time C4::Context is created would mean an interesting speed improvement, depending on the host system. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored AssignedTo|gmcharlt@gmail.com |tomascohen@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-04-14 17:52:40 UTC --- Created attachment 3926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3926 Initial patch This patch is not intended to make it into master right now, but for testing performance gains. It could serve as a basis for future work if found worth the trouble. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3926|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-04-14 18:25:49 UTC --- Created attachment 3927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3927 Simplified patch Remove unneeded changes to rewrite-config.PL -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-07-07 17:44:39 UTC --- I'd like to state FRT that I find interesting the use of C4::Context->ismemcached and C4::Context->memcached outside C4::Context, as 1) C4::Context is used everywhere memcached is used 2) It will simplify code in those places: Biblio.pm: my $servers = C4::Context->config('memcached_servers'); if ($servers) { require Memoize::Memcached; import Memoize::Memcached qw(memoize_memcached); my $memcached = { servers => [$servers], key_prefix => C4::Context->config('memcached_namespace') || 'koha', }; memoize_memcached( 'GetMarcStructure', memcached => $memcached, expire_time => 600 ); #cache for 10 minutes } To: if (C4::Context->ismemcached) { require Memoize::Memcached; import Memoize::Memcached qw(memoize_memcached); memoize_memcached( 'GetMarcStructure', memcached => C4::Context->memcached, expire_time => 600 ); #cache for 10 minutes } -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3927|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-08-17 13:20:13 UTC --- Created attachment 5045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5045 Simplified patch, comments added (for slef) Just commented the 'memcached stuff' part of the code. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 dev_patches@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dev_patches@biblibre.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Signed Off |Needs Signoff --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-19 12:37:21 UTC --- I am a bit confused that this is set to 'Signed off' - I can't find a comment or signed-off patch. I am resetting it to 'Needs Signoff' so that it does not get missed. - Plz change back if I missed something. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-09-20 20:04:53 UTC --- (In reply to comment #5)
I am a bit confused that this is set to 'Signed off' - I can't find a comment or signed-off patch. I am resetting it to 'Needs Signoff' so that it does not get missed. - Plz change back if I missed something.
Kf, don't know what to say. Maybe the biblibre folks forgot to send the patch. It's a pity. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Federico Rinaudo <frinaudo@infocpt.com.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frinaudo@infocpt.com.ar Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 --- Comment #7 from Federico Rinaudo <frinaudo@infocpt.com.ar> 2011-09-22 13:04:39 UTC --- Created attachment 5537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5537 Signed-off patch I tested this on a fresh install. It worked as expected with memcached running, and stopped too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 MJ Ray (software.coop) <mjr@ttllp.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5045|0 |1 is obsolete| | Attachment #5537|0 |1 is obsolete| | --- Comment #8 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-09-23 10:35:25 UTC --- Created attachment 5559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5559 Bug 6193 - Use memcached cache koha-conf.xml configuration variables Basically I add some code to Context.pm so it stores koha-conf.xml config vars in memcached server. It is arguable whether this is an improvement or not, tests are needed to conclude something about this. Error handling was an issue with Cache::Memcached, I tried to do it the simplest I could. Note: As it was pointless to read the xml file to get the memcached server info for accessing them for retreiving the info in the koha-conf.xml file... I passed those values through apache's SetEnv. These variables are set acordingly through the install scripts and commented out if koha was setup not to use it. Bug 6193 - Properly comment the code Required by slef. Regards To+ Signed-off-by: Federico Rinaudo <frinaudo@infocpt.com.ar> Signed-off-by: MJ Ray <mjr@phonecoop.coop> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |Rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:40:13 UTC --- Updating version : This ENH could be in Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:46 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7119 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-25 17:55:30 UTC --- Some performance tests: (using an updated version of benchmark_circulation i'll push soon) WITHOUT THIS PATCH: misc/load_testing/benchmark_circulation.pl http://koha-community:8080/cgi-bin/koha/ test test Authentication successful -------------- Koha circulation benchmarking utility -------------- Benchmarking with 20 occurences of each operation and 30 concurrent sessions Load testing staff client dashboard page 27460ms 0.728332119446468 pages/sec Load testing catalog detail page 29092ms 0.687474219716761 biblios/sec Load testing patron detail page 32413ms 0.617036374294265 borrowers/sec Load testing patron search page 60148ms 0.665026268537607 borrowers/sec WITH THIS PATCH: misc/load_testing/benchmark_circulation.pl http://koha-community:8080/cgi-bin/koha/ test test Authentication successful -------------- Koha circulation benchmarking utility -------------- Benchmarking with 20 occurences of each operation and 30 concurrent sessions Load testing staff client dashboard page 26654ms 0.750356419299167 pages/sec Load testing catalog detail page 25688ms 0.77857365306758 biblios/sec Load testing patron detail page 29681ms 0.67383174421347 borrowers/sec Load testing patron search page 56895ms 0.703049477106951 borrowers/sec => the gain is not huge, but real. This is due to the fact that the decoding of the XML is replaced by the time for Koha to reach memcache server & get an answer. We should not miss that memcache is more dedicated to removing load on mySQL than gaining speed. I also have a patch from Ian that change the conf into a YAML file. It seems decoding a YAML is very fast. I'll run the tests as well, attach ian patch here and report the results. Thus we will see which patch give the best speed and decide which we can/should apply. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-11-25 18:04:17 UTC --- I heard about using YAML and agree it would be a good improvement. Just would like to say that in our production sites the main concern was filesystem I/O, as everything is stored in a SAN, and have multiple sites on the same virtual VPS. I also added in #c3 that i find more suitable the way memcached is handled in C4::Context and posibbly reused across the Koha modules, meaning having a single memcached object, and ismemcached variable to test. Regards To+ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-25 18:06:52 UTC --- memcached is about scalability, In my opinion even if YAML is faster, both should be applied. People who need to scale up, can switch on the memcaching that way. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-19 09:35:30 UTC --- QA Comment: Patch has been tested and signed off by two individuals. Code looks good and promises performance increase when (optionally) using memcached. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-27 16:18:35 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-28 16:51:25 UTC --- NYTPROF testing: before running NYTPROF, you must export variable & load at least one page (to fill memcache) This is done by (on your shell): export MEMCACHED_SERVERS=127.0.0.1:11211 export MEMCACHED_NAMESPACE=xxxx (xxxx= whatever you've set in your Apache) Then, load mainpage on firefox at least once (to store the config file in memcache) then, you can run: perl -d:NYTProf mainpage.pl The results show you don't call read_config_file sub anymore. The timing go from 230ms to 2.56ms on my test computer: $self = $memcached->get('kohaconf'); # spent 2.56ms making 2 calls to Cache::Memcached::get, avg 1.28ms/call (side question: why the hell does my last benchmarks show no gain ?) BEFORE THE PATCH: Profile of mainpage.pl for 2.12s (of 2.74s), executing 197477 statements and 59679 subroutine calls in 279 source files and 80 string evals. AFTER THE PATCH: Profile of mainpage.pl for 1.70s (of 2.14s), executing 137323 statements and 33090 subroutine calls in 273 source files and 79 string evals. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-28 17:10:28 UTC --- QA question: this patch requires that the memcache parameters are in Apache SetEnv variables. BUT they are still in the Koha config file. It means we have them in 2 places, and that's wrong. tcohen, did I miss something ? Why haven't you updated memcache to use only SetEnv everywhere ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-28 17:34:16 UTC --- IRC with tcohen a few minuts ago: <tcohen> i've been conservative in the way I propose several enhancements <tcohen> assuming big changes can lead the enhancement not to be included <tcohen> I can send a patch that solves this <tcohen> and can even send a patch that reuses Context->memcached <paul_p> tcohen, mmm... in fact, I think that if I had seen this problem before, I could have proposed "failed QA", even if it's usefull. You're highly welcomed to send a patch finishing the job ! <tcohen> ok <tcohen> a patch against master, that uses setenv -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-12-30 12:25:25 UTC --- Created attachment 6971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6971 Follow up: use SetEnv and remove memcached from koha-conf.xml I have a SetEnv-only version, but thought htis would be simple and clean. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5559|0 |1 is obsolete| | --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-30 13:22:35 UTC --- Comment on attachment 5559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5559 Bug 6193 - Use memcached cache koha-conf.xml configuration variables This patch has been pushed. follow-up still to test & push -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion Blocks| |7248 --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-03 09:12:55 UTC --- linking this patch to 7248 and setting to "in discussion", as they overlap -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6000 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #22 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-12 19:36:21 UTC --- I can't figure out how to test this follow-up which is supposed to change it so that the system uses SetEnv. It doesn't have an example of the use of SetEnv. All it does is remove the memcached configuration from koha-conf.xml. Help! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6971|0 |1 is obsolete| | --- Comment #23 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-13 16:25:59 UTC --- Created attachment 7630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7630 Bug 6193 - Follow up: use SetEnv and remove memcached from koha-conf.xml Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Confirmed that memcached is still being used after the memcached configuration in koha-conf.xml was removed, and the following two lines were added to both virtual hosts in koha-httpd.conf: SetEnv MEMCACHED_SERVERS "127.0.0.1:11211" SetEnv MEMCACHED_NAMESPACE "KOHA" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA Version|master |rel_3_8 --- Comment #24 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-20 22:30:38 UTC --- QA comment: this patch switches all memoize calls to ENV / koha-httpd.conf. code is OK, but does not apply to new/bug_6193 branch due to some fixes chris_c made to expiry_time. I'll have to made a tiny change to the patch to remove expiry_time from the follow-up and move it to C4::Context and push this patch to master branch directly -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #25 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-21 12:17:48 UTC --- Patch pushed Note that the expiry_time set to 600 seconds has been moved at the right place (in the memcached handler), this is an extension of bug 7432 that chris_c made a few weeks ago. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Bug 6193 depends on bug 6000, which changed state. Bug 6000 Summary: Performance enhancements for C4::Context and C4::Languages http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Bug 6193 depends on bug 7119, which changed state. Bug 7119 Summary: general code-cleaning, tidy/whitespace omnibus http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11167 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org