[Bug 7254] New: Show pending orders from baskets with closedate > 180 days
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7254 Bug #: 7254 Summary: Show pending orders from baskets with closedate > 180 days Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: PATCH-Sent Component: Acquisitions AssignedTo: m.de.rooy@rijksmuseum.nl ReportedBy: m.de.rooy@rijksmuseum.nl QAContact: ian.walls@bywatersolutions.com Current code for selecting pending orders does not select orders from baskets with a closedate > 180 days. The code in Acquisition.pm already includes a FIXME for that. IMHO this part of the where clause should just be removed; an order is pending until it is filled. If you do not want to fill it, delete it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7254 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-23 12:55:55 UTC --- Created attachment 6376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6376 Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7254 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7254 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Passed QA --- Comment #2 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-23 13:57:16 UTC --- SQL-only change that removes an unjustified restriction. Signing off and passing QA in one. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7254 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-23 13:58:33 UTC --- (In reply to comment #2)
SQL-only change that removes an unjustified restriction. Signing off and passing QA in one.
Within an hour! Great.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7254 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-24 14:46:29 UTC --- Comment: this patch also removes the OR clodedate IS NULL, that is not related to the 180 days limit. Baskets were not removed if they are not closed. It seems logic to consider that a basket is pending if there are still things to recieve, the SQL query do that, so I accept the patch Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7254 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org