[Bug 39321] New: Hide subfield tag for fixed length control fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Bug ID: 39321 Summary: Hide subfield tag for fixed length control fields Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 39293 I think Koha intends to hide the subfield tag entirely when one is viewing a control field? If you open up a bib or authority for editing in the basic editor, you'll see that the control fields show a subfield tag of "00." You'll also notice that the second zero is cut off. This was true before Bug 39293, but those boxes made me think about it more :) I started to patch it so that both zeros would show, but it really looks like the intent is to hide them instead: style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]" https://github.com/Koha-Community/Koha/blob/10d781c7b98d4e90e131c478638f3dc4... This maybe changed with bug 22399, back in 20.11? I sure didn't notice it at the time. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 [Bug 39293] Remove box around subfield tag in basic editor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Actually, looks like we also intend to hide the subfield label for these, so we would not show "fixed length control field" or "control field." Looks like this check in addbiblio.tt isn't returning a value for some reason? fixedfield => $tag < 10 ? 1 : 0, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 179248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179248&action=edit Bug 39321: Hide subfield tag information for control fields in bib and authority editing This applies only to the basic editor, but for both bibs and authorities To test: 1 - Open a bib in the basic editor, see that the control fields show the subfield tag value label and that the value of 00 is slightly cut off in the display 2 - Open an authority in the basic editor and confirm same 3 - apply patch 4 - reload your records and see that the subfield value and label are now hidden for control fields in both bib and authrority editing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- I think it's more likely that it never worked to hide the 00 - I'm looking at a screenshot in the 16.11 manual, and at that point the 00 was showing. For it to ever work, the script would have had to set fixedfield in @subfields_data rather than just in %tagdata, and I can't find that it ever did. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179248|0 |1 is obsolete| | --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179293&action=edit Bug 39321: Hide subfield tag information for control fields in bib and authority editing This applies only to the basic editor, but for both bibs and authorities To test: 1 - Open a bib in the basic editor, see that the control fields show the subfield tag value label and that the value of 00 is slightly cut off in the display 2 - Open an authority in the basic editor and confirm same 3 - apply patch 4 - reload your records and see that the subfield value and label are now hidden for control fields in both bib and authrority editing Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop@gmail.com --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- *** Bug 39476 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179293|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 181151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181151&action=edit Bug 39321: Hide subfield tag information for control fields in bib and authority editing This applies only to the basic editor, but for both bibs and authorities To test: 1 - Open a bib in the basic editor, see that the control fields show the subfield tag value label and that the value of 00 is slightly cut off in the display 2 - Open an authority in the basic editor and confirm same 3 - apply patch 4 - reload your records and see that the subfield value and label are now hidden for control fields in both bib and authrority editing Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org