[Bug 22396] New: sip script does not start the server correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Bug ID: 22396 Summary: sip script does not start the server correctly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: tomascohen@gmail.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Target Milestone: --- [vagrant@kohadevbox:~/kohaclone (master) ✭]% sudo koha-sip --verbose --start kohadev [kohadev-koha@kohadevbox:/home/vagrant/kohaclone (master) ✹ ✭]% misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 -m patron_information Attempting socket connection to localhost:6001...connected! SEND: 9300CNterm1|COterm1|CPCPL| Use of uninitialized value $data in concatenation (.) or string at misc/sip_cli_emulator.pl line 314. READ: Use of uninitialized value $data in pattern match (m//) at misc/sip_cli_emulator.pl line 265. Login Failed! The logs say: ==> /var/log/koha/kohadev/sip-output.log <== unable to locate Koha configuration file koha-conf.xml at /home/vagrant/kohaclone/C4/Context.pm line 244, <STDIN> line 1. Can't call method "config" on unblessed reference at /home/vagrant/kohaclone/Koha/Database.pm line 56, <STDIN> line 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- kohadev+ 28268 0.0 0.0 18612 192 ? S 11:10 0:00 daemon --name=kohadev-koha-sip --errlog=/var/log/koha/kohadev/sip-error.log --stdout=/var/log/koha/kohadev/sip.log --output=/var/log/koha/kohadev/sip-output.log --verbose=1 --respawn --delay=30 --pidfiles=/var/run/koha/kohadev --user=kohadev-koha.kohadev-koha -- perl /home/vagrant/kohaclone/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|sip script does not start |koha-sip script does not |the server correctly |start the server correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This is because of a typo and the fact that KOHA_CONF is not set in ENV. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85562&action=edit Bug 22396: Make koha-sip set KOHA_HOME and KOHA_CONF correctly This patch corrects a typo, and exports KOHA_CONF as other scripts do. To test: - Apply this patch - Run: $ # in kohadevbox $ perl misc4dev/cp_debian_files.pl - Try the new script $ sudo koha-sip --start kohadev => SUCCESS: tail -f /var/log/koha/kohadev/sip* doesn't show fatal errors anymore - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 [Bug 18562] Add koha-sip script to handle SIP servers for instances -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85562|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85563&action=edit Bug 22396: Make koha-sip set KOHA_HOME and KOHA_CONF correctly This patch corrects a typo, and exports KOHA_CONF as other scripts do. To test: - Apply this patch - Run: $ # in kohadevbox $ perl misc4dev/cp_debian_files.pl - Try the new script $ sudo koha-sip --start kohadev => SUCCESS: tail -f /var/log/koha/kohadev/sip* doesn't show fatal errors anymore - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Bug 22396 depends on bug 18562, which changed state. Bug 18562 Summary: Add koha-sip script to handle SIP servers for instances https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- missing 18562 dependency for 18.05.x, wont backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org