[Bug 7226] New: can't add tags on list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7226 Bug #: 7226 Summary: can't add tags on list Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 - low Component: Tools AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: ian.walls@bywatersolutions.com when on a list and choosing to tag multiple items the tags are not added and there is no error. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7226 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|Tools |Virtual Shelves Version|unspecified |master AssignedTo|gmcharlt@gmail.com |oleonard@myacpl.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7226 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-12-06 15:00:10 UTC --- Created attachment 6600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6600 Proposed fix Incorrect check for TagsInputOnList was preventing the right JavaScript from being triggered, and markup was nested inside the wrong logic for the confirmation message to be displayed consistently. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7226 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff Summary|can't add tags on list |Can't add tags on list -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7226 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6600|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-12-06 16:05:36 UTC --- Created attachment 6602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6602 [SIGNED-OFF] Bug 7226 - can't add tags on list Incorrect check for TagsInputOnList was preventing the right JavaScript from being triggered, and markup was nested inside the wrong logic for the confirmation message to be displayed consistently. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7226 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7226 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-12-06 16:09:21 UTC --- Created attachment 6603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6603 [SIGNED-OFF] Bug 7280 - can't place hold without selecting on list JavaScript was looking for clicks on links with class "hold," and incorrectly triggering the check for checked checkboxes. Making the selection stricter lets the JS function as it should while allowing people to place individual holds directly. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7226 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6603|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-12-06 16:09:50 UTC --- Comment on attachment 6603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6603 [SIGNED-OFF] Bug 7280 - can't place hold without selecting on list Attached wrong. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7226 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-16 17:16:56 UTC --- QA comment: small patch, template change only prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. ok passed QA Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7226 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7226 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org