[Bug 10943] New: impossible to check and make fines when borrowers flag is desactivate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Bug ID: 10943 Summary: impossible to check and make fines when borrowers flag is desactivate Change sponsored?: --- Product: Koha Version: 3.12 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-vila@ccsr.qc.ca QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When a borrower has those flags: -circulate -catalog -reserveforothers -borrow -updatecharges He can not make and check fines on a other borrower. He can make check in and check out but he has not a access to the fines tab. See video. http://communaute.koha.ccsr.qc.ca/wp-content/uploads/2013/09/flags.swf Thanks Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|3.12 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It appears you also need the borrowers permission - I am not sure if this is intentional: pay.pl: 53 flagsrequired => { borrowers => 1, updatecharges => $updatecharges_permissions }, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|impossible to check and |Impossible to manage fines |make fines when borrowers |without borrowers |flag is desactivate |permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- (In reply to Katrin Fischer from comment #1)
It appears you also need the borrowers permission - I am not sure if this is intentional:
pay.pl: 53 flagsrequired => { borrowers => 1, updatecharges => $updatecharges_permissions },
Thanks Katrin. It works with borrowers permission. Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should think about changing this - or make all checks consistent, like not showing the fines tab when the user doesn't have all needed permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Thomas Wright <tomsStudy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED CC| |tomsStudy@gmail.com --- Comment #4 from Thomas Wright <tomsStudy@gmail.com> --- I' working on this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 --- Comment #5 from Thomas Wright <tomsStudy@gmail.com> --- Created attachment 35261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35261&action=edit Bug 10943 - Impossible to manage fines without borrowers permission Added check for borrowers permission as that is also required when accessing fines. Test Plan: -Search for a patron from an account without the 'borrowers' permission and with the 'updatecharges' permission. *The fines tab should not be present. -Update the account's permissions to include the 'borrowers' permission *The fines tab should now be present. -Update the account's permissions so it has neither 'borrowers' or 'updatecharges' *The fines tab should not be present -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Thomas Wright <tomsStudy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35261|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35355&action=edit [SIGNED OFF] Bug 10943 - Impossible to manage fines without borrowers permission Added check for borrowers permission as that is also required when accessing fines. Test Plan: -Search for a patron from an account without the 'borrowers' permission and with the 'updatecharges' permission. *The fines tab should not be present. -Update the account's permissions to include the 'borrowers' permission *The fines tab should now be present. -Update the account's permissions so it has neither 'borrowers' or 'updatecharges' *The fines tab should not be present Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, wondering if the other way around would make more sense: Allow paying fines without the permission to manage borrowers. I think the permission page doesn't suggest that you'd need to combine both. What do people think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)
Hm, wondering if the other way around would make more sense: Allow paying fines without the permission to manage borrowers.
I think the permission page doesn't suggest that you'd need to combine both.
What do people think?
I would agree with Katrin. It should be possible to deal with fines and charges while not having the ability to edit the patron's details. That gives more flexibility for permissions, whereas this implementation gives less flexibility. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- I agree and will get the students this year to switch it around -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org