[Bug 27408] New: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Bug ID: 27408 Summary: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We need to update input type="number" with reference to ACC2 on intranet-tmpl/prog/en/modules/members/mancredit.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Blocks| |26962 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 [Bug 26962] Koha notice/slips/receipts should print in true black (#000000) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26962 |26926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 [Bug 26926] Update all occurrences of <input type="number"> to apply ACC2 coding guideline https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 [Bug 26962] Koha notice/slips/receipts should print in true black (#000000) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mazen.i.khallaf@gmail.com Assignee|koha-bugs@lists.koha-commun |mazen.i.khallaf@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 --- Comment #1 from Mazen Khallaf <mazen.i.khallaf@gmail.com> --- Created attachment 115396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115396&action=edit Bug 27408: pdate intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- There is more to do when converting a "type='number'" input: If present, the "step," "max," and "min" attributes should be removed too. They are invalid if applied to a standard text input. Example errors from the w3c validator: Error: Attribute step not allowed on element input at this point. Error: Attribute min not allowed on element input at this point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115396|0 |1 is obsolete| | --- Comment #3 from Mazen Khallaf <mazen.i.khallaf@gmail.com> --- Created attachment 115467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115467&action=edit Bug 27408: pdate intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115467|0 |1 is obsolete| | --- Comment #4 from Mazen Khallaf <mazen.i.khallaf@gmail.com> --- Created attachment 115469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115469&action=edit Bug 27408: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115469|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115483&action=edit Bug 27408: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Whoops, I was too hasty with this signoff. The regex validating the modified field doesn't allow for currency-formatted values like "1.00" because of the dot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115483|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115549&action=edit Bug 27408: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115550&action=edit Bug 27408: (follow-up) Updates to accommodate currency entry This patch makes two modifications in order to allow the entry of currency strings (e.g. 1.25). - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual credit "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mazen.i.khallaf@gmail.com |koha-bugs@lists.koha-commun | |ity.org CC|mazen.i.khallaf@gmail.com | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115549|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 117014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117014&action=edit Bug 27408: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115550|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 117015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117015&action=edit Bug 27408: (follow-up) Updates to accommodate currency entry This patch makes two modifications in order to allow the entry of currency strings (e.g. 1.25). - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual credit "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #11 from David Nind <david@davidnind.com> --- Testing notes: - For step 2 of the test plan, input type="text" should be input type="number", the same as bug 27410 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117014|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117707&action=edit Bug 27408: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117015|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117708&action=edit Bug 27408: (follow-up) Updates to accommodate currency entry This patch makes two modifications in order to allow the entry of currency strings (e.g. 1.25). - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual credit "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch updates release notes| |occurrences of input | |type="number" in | |intranet-tmpl/prog/en/modul | |es/members/mancredit.tt to | |use <input type="text" | |inputmode="numeric" | |pattern="[0-9]*"> as per | |the accessibility coding | |guideline ACC2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch updates |This patch updates release notes|occurrences of input |occurrences of input |type="number" in |type="number" in |intranet-tmpl/prog/en/modul |intranet-tmpl/prog/en/modul |es/members/mancredit.tt to |es/members/mancredit.tt to |use <input type="text" |use <input type="text" |inputmode="numeric" |inputmode="numeric" |pattern="[0-9]*"> as per |pattern="^\d+(\.\d{2})?$"> |the accessibility coding |as per the accessibility |guideline ACC2. |coding guideline ACC2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- I've dediced not pushed to 20.11.x changes for ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Text to go in the|This patch updates |This patch updates release notes|occurrences of input |occurrences of input |type="number" in |type="number" in |intranet-tmpl/prog/en/modul |intranet-tmpl/prog/en/modul |es/members/mancredit.tt to |es/members/mancredit.tt to |use <input type="text" |use 'input type="text" |inputmode="numeric" |inputmode="numeric" |pattern="^\d+(\.\d{2})?$"> |pattern="^\d+(\.\d{2})?$"' |as per the accessibility |as per the accessibility |coding guideline ACC2. |coding guideline ACC2. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org