[Bug 21722] New: Update C4::Accounts::chargelostitem to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Bug ID: 21722 Summary: Update C4::Accounts::chargelostitem to use Koha::Account->add_debit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org All account handling should go via the Koha::Account class. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81889&action=edit Bug 21722: Use Koha::Account->add_debit in chargelostitem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test plan: Prior to applying patch, both db_dependent/Circulation/Chargelostitem.t and db_dependent/Accounts.t tests should pass. After applying patch the above two tests should still pass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81889|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83164&action=edit Bug 21722: Use Koha::Account->add_debit in chargelostitem This patch updates C4::Accounts::chargelostitem to use the newly available add_debit method from Koha::Account. Known Side Effects: If the FinesLog is enabled then the 'action' recorded will change from the generic `create_fee` (for both the lost charge and any associated processing charge) to the more descriptive terms `create_processing` and `create_list_item`. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83164|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83172&action=edit Bug 21722: Use Koha::Account->add_debit in chargelostitem This patch updates C4::Accounts::chargelostitem to use the newly available add_debit method from Koha::Account. Known Side Effects: If the FinesLog is enabled then the 'action' recorded will change from the generic `create_fee` (for both the lost charge and any associated processing charge) to the more descriptive terms `create_processing` and `create_list_item`. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I will add tests for the new/altered behaviour here.. the existing tests do not cover the effect of the FinesLog at all right now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83181&action=edit Bug 21722: Tidy up tests and increase coverage This patch moved the chargelostitem 'branchcode' test to within the 'chargelostitem' subtest block and adds tests for additional accountline fields that should be getting set by this method. Sponsored-by: PTFS Europe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83172|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83182&action=edit Bug 21722: Use Koha::Account->add_debit in chargelostitem This patch updates C4::Accounts::chargelostitem to use the newly available add_debit method from Koha::Account. Known Side Effects: If the FinesLog is enabled then the 'action' recorded will change from the generic `create_fee` (for both the lost charge and any associated processing charge) to the more descriptive terms `create_processing` and `create_list_item`. Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83181|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83186&action=edit Bug 21722: Tidy up tests and increase coverage This patch moves the chargelostitem 'branchcode' test to within the 'chargelostitem' subtest block in t/db_dependent/Accounts.t. It also adds tests for additional accountline fields that should be getting set by this method and adds tests for ProcessingFeeNote before removing t/db_dependent/Circulation/Chargelostitem.t which covered this previously. Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83182|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83187&action=edit Bug 21722: Use Koha::Account->add_debit in chargelostitem This patch updates C4::Accounts::chargelostitem to use the newly available add_debit method from Koha::Account. Known Side Effects: If the FinesLog is enabled then the 'action' recorded will change from the generic `create_fee` (for both the lost charge and any associated processing charge) to the more descriptive terms `create_processing` and `create_list_item`. Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test Plan 1) Confirm t/db_dependant/Account.t and t/db_dependant/Circulation/Chargelostitem.t test pass before applying any patches. 2) Confirm that one test fails in t/db_dependant/Account.t after applying the first patch which cleans up the tests and adds additional coverage (The test that's expected to fail is one that tests the value of the 'note' field is empty and it fails due to the difference between q{} and undef) 3) Apply the final patch and note the tests now pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83186|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83189&action=edit Bug 21722: Tidy up tests and increase coverage This patch moves the chargelostitem 'branchcode' test to within the 'chargelostitem' subtest block in t/db_dependent/Accounts.t. It also adds tests for additional accountline fields that should be getting set by this method and adds tests for ProcessingFeeNote before removing t/db_dependent/Circulation/Chargelostitem.t which covered this previously. Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83187|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83190&action=edit Bug 21722: Use Koha::Account->add_debit in chargelostitem This patch updates C4::Accounts::chargelostitem to use the newly available add_debit method from Koha::Account. Known Side Effects: If the FinesLog is enabled then the 'action' recorded will change from the generic `create_fee` (for both the lost charge and any associated processing charge) to the more descriptive terms `create_processing` and `create_list_item`. Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83189|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83197&action=edit Bug 21722: Tidy up tests and increase coverage This patch moves the chargelostitem 'branchcode' test to within the 'chargelostitem' subtest block in t/db_dependent/Accounts.t. It also adds tests for additional accountline fields that should be getting set by this method and adds tests for ProcessingFeeNote before removing t/db_dependent/Circulation/Chargelostitem.t which covered this previously. Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83190|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83198&action=edit Bug 21722: Use Koha::Account->add_debit in chargelostitem This patch updates C4::Accounts::chargelostitem to use the newly available add_debit method from Koha::Account. Known Side Effects: If the FinesLog is enabled then the 'action' recorded will change from the generic `create_fee` (for both the lost charge and any associated processing charge) to the more descriptive terms `create_processing` and `create_lost_item`. Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21683 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 [Bug 21683] Remove accountlines.accountno -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83197|0 |1 is obsolete| | Attachment #83198|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 84276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84276&action=edit Bug 21722: Tidy up tests and increase coverage This patch moves the chargelostitem 'branchcode' test to within the 'chargelostitem' subtest block in t/db_dependent/Accounts.t. It also adds tests for additional accountline fields that should be getting set by this method and adds tests for ProcessingFeeNote before removing t/db_dependent/Circulation/Chargelostitem.t which covered this previously. Sponsored-by: PTFS Europe Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 84277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84277&action=edit Bug 21722: Use Koha::Account->add_debit in chargelostitem This patch updates C4::Accounts::chargelostitem to use the newly available add_debit method from Koha::Account. Known Side Effects: If the FinesLog is enabled then the 'action' recorded will change from the generic `create_fee` (for both the lost charge and any associated processing charge) to the more descriptive terms `create_processing` and `create_lost_item`. Sponsored-by: PTFS Europe Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Bug 21722 depends on bug 21002, which changed state. Bug 21002 Summary: Add Koha::Account::add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84277|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85173&action=edit Bug 21722: Tidy up tests and increase coverage This patch moves the chargelostitem 'branchcode' test to within the 'chargelostitem' subtest block in t/db_dependent/Accounts.t. It also adds tests for additional accountline fields that should be getting set by this method and adds tests for ProcessingFeeNote before removing t/db_dependent/Circulation/Chargelostitem.t which covered this previously. Sponsored-by: PTFS Europe Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85174&action=edit Bug 21722: Use Koha::Account->add_debit in chargelostitem This patch updates C4::Accounts::chargelostitem to use the newly available add_debit method from Koha::Account. Known Side Effects: If the FinesLog is enabled then the 'action' recorded will change from the generic `create_fee` (for both the lost charge and any associated processing charge) to the more descriptive terms `create_processing` and `create_lost_item`. Sponsored-by: PTFS Europe Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21683 |21728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 [Bug 21683] Remove accountlines.accountno https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Bug 21722 depends on bug 21747, which changed state. Bug 21747 Summary: Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to stable branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org