[Bug 11672] New: Untranslatable report areas in step 1 of Guided Reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Bug ID: 11672 Summary: Untranslatable report areas in step 1 of Guided Reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The guided reports UI shows a drop-down box with "Circulation", "Catalogue", etc. These are hard-coded in C4/Reports/Guided.pm (the @REPORT_AREA hash) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@pttk.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen@pttk.fi> --- Created attachment 27955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27955&action=edit Fix untranslatable report areas The guided reports UI shows a drop-down box with "Circulation", "Catalogue", etc. These are hard-coded in C4/Reports/Guided.pm (the @REPORT_AREA hash) To test: 1) cd misc/translator 2) perl translate update xx-YY 3) there should be no translations msgid for the report area names in the po/xx-YY-i-staff-t-prog-v-3006000.po 4) apply patch 5) perl translate update xx-YY 6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the msgid - search for "translate_report_areas" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This looks good to me as far as functionality goes, but Koha's templates use the American "Catalog" instead of "Catalogue." Not really worth failing the patch, but I disagree with this non-standard indentation in the template: [% BLOCK translate_report_areas %] [% SWITCH area %] [% CASE 'CIRC' %]Circulation [% CASE 'CAT' %]Catalogue [% CASE 'PAT' %]Patrons [% CASE 'ACQ' %]Acquisition [% CASE 'ACC' %]Accounts [% END %] [% END %] I would prefer to see standard indentation on a line-by-line basis. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 --- Comment #3 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Owen Leonard from comment #2)
This looks good to me as far as functionality goes, but Koha's templates use the American "Catalog" instead of "Catalogue."
C4/Reports/Guided.pm, where those values came from: [CAT => "Catalogue"],
Not really worth failing the patch, but I disagree with this non-standard indentation in the template:
[% BLOCK translate_report_areas %] [% SWITCH area %] [% CASE 'CIRC' %]Circulation [% CASE 'CAT' %]Catalogue [% CASE 'PAT' %]Patrons [% CASE 'ACQ' %]Acquisition [% CASE 'ACC' %]Accounts [% END %] [% END %]
I would prefer to see standard indentation on a line-by-line basis.
Define standard indentation. I see no mention of indentation for the templates in the coding guidelines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to paxed from comment #3)
(In reply to Owen Leonard from comment #2)
This looks good to me as far as functionality goes, but Koha's templates use the American "Catalog" instead of "Catalogue."
C4/Reports/Guided.pm, where those values came from: [CAT => "Catalogue"],
Yes of course it's logical to have used that spelling since you were referencing the text in the script. However you will find that in the default en templates the standard spelling is "Catalog."
[% BLOCK translate_report_areas %] [% SWITCH area %] [% CASE 'CIRC' %]Circulation [% CASE 'CAT' %]Catalogue [% CASE 'PAT' %]Patrons [% CASE 'ACQ' %]Acquisition [% CASE 'ACC' %]Accounts [% END %] [% END %]
Define standard indentation. I see no mention of indentation for the templates in the coding guidelines.
Again, sometimes the standard is simply, "what you see consistently in other templates." Indentation isn't always consistent, but generally speaking I would consider standard indentation to be: [% BLOCK translate_report_areas %] [% SWITCH area %] [% CASE 'CIRC' %]Circulation [% CASE 'CAT' %]Catalogue [% CASE 'PAT' %]Patrons [% CASE 'ACQ' %]Acquisition [% CASE 'ACC' %]Accounts [% END %] [% END %] I think this kind of indentation helps others more easily understand the logical structure of the template tags. It also works better with a text editor's indentation tools. That's just my opinion of course and a discussion on the developer's list could help sort it out. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 31125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31125&action=edit Bug 11672: (regression test) get_report_areas gets tested This patch introduces a unit test for the new get_report_areas functionality. To try it, run $ prove t/db_dependent/Reports_Guided.t It is expected to have 16 tests defined, and to fail the introduced one -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27955|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 31126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31126&action=edit Bug 11672: Untranslatable dropdown on Guided Reports and dictionary This patch removes hardcoded descriptions and sets them in the templates using the variable content as id. To test, create a new guided report and verify the 'module to report on' dropdown shows as usual [1]. Functionality shouldn't get changed. The patch also changes the dictionary pages where 'area' should be displayed/selectable with the same strings as the guided reports. Try all the possible disctionary pages. The last page when creating a dictionary now shows the 'area description' instead of the code. The same happens to the dictionary list once you have dictionaries saved. [1] The following texts get changed: Catalogue -> Catalog Acquisition -> Acquisitions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|pasi.kallinen@pttk.fi |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 31187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31187&action=edit Bug 11672: (followup) warnings tested -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31125|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31188&action=edit [SIGNED-OFF] Bug 11672: (regression test) get_report_areas gets tested This patch introduces a unit test for the new get_report_areas functionality. To try it, run $ prove t/db_dependent/Reports_Guided.t It is expected to have 16 tests defined, and to fail the introduced one Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31126|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31189&action=edit [SIGNED-OFF] Bug 11672: Untranslatable dropdown on Guided Reports and dictionary This patch removes hardcoded descriptions and sets them in the templates using the variable content as id. To test, create a new guided report and verify the 'module to report on' dropdown shows as usual [1]. Functionality shouldn't get changed. The patch also changes the dictionary pages where 'area' should be displayed/selectable with the same strings as the guided reports. Try all the possible disctionary pages. The last page when creating a dictionary now shows the 'area description' instead of the code. The same happens to the dictionary list once you have dictionaries saved. [1] The following texts get changed: Catalogue -> Catalog Acquisition -> Acquisitions Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31187|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31190&action=edit [SIGNED-OFF] Bug 11672: (followup) warnings tested Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31808&action=edit Bug 11672: (regression test) get_report_areas gets tested This patch introduces a unit test for the new get_report_areas functionality. To try it, run $ prove t/db_dependent/Reports_Guided.t It is expected to have 16 tests defined, and to fail the introduced one Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31809&action=edit Bug 11672: Untranslatable dropdown on Guided Reports and dictionary This patch removes hardcoded descriptions and sets them in the templates using the variable content as id. To test, create a new guided report and verify the 'module to report on' dropdown shows as usual [1]. Functionality shouldn't get changed. The patch also changes the dictionary pages where 'area' should be displayed/selectable with the same strings as the guided reports. Try all the possible disctionary pages. The last page when creating a dictionary now shows the 'area description' instead of the code. The same happens to the dictionary list once you have dictionaries saved. [1] The following texts get changed: Catalogue -> Catalog Acquisition -> Acquisitions Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31810&action=edit Bug 11672: (followup) warnings tested Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31188|0 |1 is obsolete| | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org