https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29955 CC| |lucas@bywatersolutions.com --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Steven Nickerson from comment #0)

[Mon Oct 24 17:44:39.651936 2022] [cgi:error] [pid 21984] [client x.x.x.x:56417] AH01215: Use of inherited AUTOLOAD for non-method Koha::Virtualshelf::haspermission() is deprecated at /usr/share/koha/lib/Koha/Virtualshelf.pm line 247.: /usr/share/koha/opac/cgi-bin/opac/opac-shelves.pl, referer: http://WEBSITE/cgi-bin/koha/opac-shelves.pl?op=list&public=1

return 1 if $self->is_public and haspermission( $patron->userid, { lists => 'edit_public_lists' } ); This is corrected in master with: return 1 if $self->is_public and C4::Auth::haspermission( $patron->userid, { lists => 'edit_public_lists' } ); Solved on Bug 29955: Fix method import issues This fix should be backported. Trying to catch the attention of the 22.05 RMaint: Lucas Gass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080 --- Comment #3 from Blou <philippe.blouin@inlibro.com> --- Created attachment 143108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143108&action=edit Bug 29955: Fix method import issues This patch fixes this: $ prove t/db_dependent/Utils/Datatables_Virtualshelves.t t/db_dependent/Utils/Datatables_Virtualshelves.t .. 2/13 Use of inherited AUTOLOAD for non-method Koha::Virtualshelf::haspermission() is no longer allowed at /kohadevbox/koha/Koha/Virtualshelf.pm line 248. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |philippe.blouin@inlibro.com --- Comment #5 from Blou <philippe.blouin@inlibro.com> --- I attached the REBASED patch from Bug 29955 that fixed it for me in 22.05.06. Not sure if RM want to put it as-is, or rename it or ... So I signed it off, as it works for me. Marcel/QA can validate if it makes sense. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Blou from comment #5)

I attached the REBASED patch from Bug 29955 that fixed it for me in 22.05.06.

Not sure if RM want to put it as-is, or rename it or ... So I signed it off, as it works for me. Marcel/QA can validate if it makes sense.

Looks good to me. Will change status so that RMaint can pick it up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks all, this is backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.