[Bug 33749] New: Move Koha::MetadataRecord::stripWhitespaceChars into a RecordProcessor filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Bug ID: 33749 Summary: Move Koha::MetadataRecord::stripWhitespaceChars into a RecordProcessor filter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 30358 introduced the static method Koha::MetadataRecord::stripWhitespaceChars. This method should've been put on a RecordProcessor filter. I open this bug for handling that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Depends on| |30358 Status|NEW |ASSIGNED Severity|normal |enhancement Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- 100% agree here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Bug 33749 depends on bug 30358, which changed state. Bug 30358 Summary: Strip leading/trailing whitespace characters from input fields when cataloguing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152135&action=edit Bug 33749: Add TrimFields field class This patch adds a RecordProcessor filter class that takes care of performing the field cleanup that was originally done in the static method `Koha::MetadataRecord::stripWhitespaceChars`. In order to test the results, I adapted the tests to use the filter instead of the original method. To test: 1. Run: $ ktd --shell k$ prove t/Koha_MetadataRecord.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152136&action=edit Bug 33749: Use TrimFields instead of stripWhitespaceChars This patch replaces the uses of the static method with the new filter. It also moves the tests to the relevant place and removes the (now) unused method. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can we get a review from the original authors? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152135|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 156442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156442&action=edit Bug 33749: Add TrimFields field class This patch adds a RecordProcessor filter class that takes care of performing the field cleanup that was originally done in the static method `Koha::MetadataRecord::stripWhitespaceChars`. In order to test the results, I adapted the tests to use the filter instead of the original method. To test: 1. Run: $ ktd --shell k$ prove t/Koha_MetadataRecord.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass 4. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152136|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 156443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156443&action=edit Bug 33749: Use TrimFields instead of stripWhitespaceChars This patch replaces the uses of the static method with the new filter. It also moves the tests to the relevant place and removes the (now) unused method. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156442|0 |1 is obsolete| | Attachment #156443|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158338&action=edit Bug 33749: Add TrimFields field class This patch adds a RecordProcessor filter class that takes care of performing the field cleanup that was originally done in the static method `Koha::MetadataRecord::stripWhitespaceChars`. In order to test the results, I adapted the tests to use the filter instead of the original method. To test: 1. Run: $ ktd --shell k$ prove t/Koha_MetadataRecord.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass 4. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158338|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158339&action=edit Bug 33749: Add TrimFields field class This patch adds a RecordProcessor filter class that takes care of performing the field cleanup that was originally done in the static method `Koha::MetadataRecord::stripWhitespaceChars`. In order to test the results, I adapted the tests to use the filter instead of the original method. To test: 1. Run: $ ktd --shell k$ prove t/Koha_MetadataRecord.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass 4. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158340&action=edit Bug 33749: Use TrimFields instead of stripWhitespaceChars This patch replaces the uses of the static method with the new filter. It also moves the tests to the relevant place and removes the (now) unused method. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158341&action=edit Bug 33749: (QA follow-up) Tidy code for qa script Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org