https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 200272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200272&action=edit Bug 42827: Restore values to the Items expected column in parcels.pl Test plan: 1. Create an order with multiple items and receive the order in full 2. From the vendor record, click Receive shipments 3. You should be in parcels.pl and the table should show your shipments 4. The Items expected column will show 0 even though you ordered multiple items 5. Apply patch and restart_all 6. Refresh the page, the column should now show a value -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- New patch here removes an extraneous comma that was breaking a SQL query when testing this bug alone (was fixed when also testing Bug 12278). I'm not sure this is the best fix for this issue. To my mind, an "expected" item is one that has not yet been marked received on any invoice. You code makes this table show a count of items that *were* expected and have since been received. Doesn't this make "items expected" always match the value in "item count"? With the way Koha is currently structured, the count of unreceived expected items for an invoice will *always* be zero, because there is no way to attach an item to an invoice without receiving it. Maybe we just remove/hide this column? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- The sticking point here seems to be whether "Items expected" should be the total number of items ordered (aqorders.quantity) or the number of items order but not yet received (aqorders.quantity - aqorders.quantityreceived). For either interpretation we're looking only at one specific row from the aqorders table, not following the parent/child order structure Koha uses for partial receipt. For any order that is attached to an invoice, we expect aqorders.quantity to equal aqorders.quantityreceived. The "Item count" column displays aqorders.quantityreceived. So our choice here is between showing a value that always matches another value on the screen or showing a value that is always zero. Neither seems incorrect, but neither seems useful. We could make this page calculate "Item expected" using both the order that's on the invoice and its parent order. But that would be an enhancement. With the acquisitions rewrite already well underway, such an enhancement does not seem worthwhile. So all that said, I'm happy to pull this out of In Discussion, sign it off, and then immediately QA it as a trivial change. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200453|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks Andrew. Don't want to nitpick but one additional sign-off line would be great here, especially given this is an enhancement (or should this be classified as a bug fix?). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 202815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202815&action=edit Bug 42827: Restore values to the Items expected column in parcels.pl Test plan: 1. Create an order with multiple items and receive the order in full 2. From the vendor record, click Receive shipments 3. You should be in parcels.pl and the table should show your shipments 4. The Items expected column will show 0 even though you ordered multiple items 5. Apply patch and restart_all 6. Refresh the page, the column should now show a value Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Juliet Heltbridle <jheltibridle@rcplib.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202815|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if we interpret the intended use of the column correctly. The table always and only shows the sum of received order lines. In this case, the quantity and quantity_received will usually be the same, with the exception of standing orders I believe. It's still an improvement and I have no better idea. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 --- Comment #11 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.04 release. -- You are receiving this mail because: You are watching all bug changes.