[Bug 42827] New: Items expected column in parcels.pl always displays 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Bug ID: 42827 Summary: Items expected column in parcels.pl always displays 0 Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Target Milestone: --- The controller expects the sql to return an itemsexpected value but it never does so it always defaults to the hardcoded fallback of 0 To recreate: 1. Create an order with multiple items and receive the order in full 2. From the vendor record, click Receive shipments 3. You should be in parcels.pl and the table should show your shipments 4. The Items expected column will show 0 even though you ordered multiple items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 200272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200272&action=edit Bug 42827: Restore values to the Items expected column in parcels.pl Test plan: 1. Create an order with multiple items and receive the order in full 2. From the vendor record, click Receive shipments 3. You should be in parcels.pl and the table should show your shipments 4. The Items expected column will show 0 even though you ordered multiple items 5. Apply patch and restart_all 6. Refresh the page, the column should now show a value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12278 [Bug 12278] Total amount of each invoice should be displayed in invoices page (parcels.pl) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 200453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200453&action=edit Bug 42827: Restore values to the Items expected column in parcels.pl Test plan: 1. Create an order with multiple items and receive the order in full 2. From the vendor record, click Receive shipments 3. You should be in parcels.pl and the table should show your shipments 4. The Items expected column will show 0 even though you ordered multiple items 5. Apply patch and restart_all 6. Refresh the page, the column should now show a value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- New patch here removes an extraneous comma that was breaking a SQL query when testing this bug alone (was fixed when also testing Bug 12278). I'm not sure this is the best fix for this issue. To my mind, an "expected" item is one that has not yet been marked received on any invoice. You code makes this table show a count of items that *were* expected and have since been received. Doesn't this make "items expected" always match the value in "item count"? With the way Koha is currently structured, the count of unreceived expected items for an invoice will *always* be zero, because there is no way to attach an item to an invoice without receiving it. Maybe we just remove/hide this column? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org