https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Paul Hoffman <paul@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23624 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #1 from Paul Hoffman <paul@flo.org> --- I've changed the priority and severity on this bug report, along with #23624, to P2/major since the problem they solve can make Koha unusable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92845|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92904&action=edit Bug 23626 - Add a system preference to limit the number of rows of data used in a chart when viewing report results The number of rows generated by a report is potentially unlimited; this has the potential to exhaust all available memory, bringing a Koha server down to its knees. The attached patch introduces a system preference to limit the number of rows used when charting report results; at this time, and with bug #23624 fixed, that is the only aspect of reporting that loads all results into memory at once. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92905|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92908&action=edit Bug 23626 - Add a system preference to limit the number of rows of data used in a chart when viewing report results The number of rows generated by a report is potentially unlimited; this has the potential to exhaust all available memory, bringing a Koha server down to its knees. The attached patch introduces a system preference to limit the number of rows used when charting report results; at this time, and with bug #23624 fixed, that is the only aspect of reporting that loads all results into memory at once. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92910&action=edit Bug 23626: Don't enable by default -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> ---

Also, just so you know, your patches were formatted for git. I went ahead and made them into git patches for you!

*not* that is, your patches were not formatted for applying with git. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92908|0 |1 is obsolete| | Attachment #92909|0 |1 is obsolete| | Attachment #92910|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92919&action=edit Bug 23626 - Add a system preference to limit the number of rows of data used in a chart when viewing report results The number of rows generated by a report is potentially unlimited; this has the potential to exhaust all available memory, bringing a Koha server down to its knees. The attached patch introduces a system preference to limit the number of rows used when charting report results; at this time, and with bug #23624 fixed, that is the only aspect of reporting that loads all results into memory at once. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92921&action=edit Bug 23626: Don't enable by default Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #13 from Paul Hoffman <paul@flo.org> --- Here's an example from our Koha instance: SELECT monthname(timestamp) AS month, year(timestamp) AS year, count(itemnumber) AS count FROM items WHERE timestamp BETWEEN <<Between (yyyy-mm-dd)|date>> AND <<and (yyyy-mm-dd)|date>> GROUP BY year(timestamp), month(timestamp) I have screenshots showing the steps in charting this -- I can attach them if they're useful. However, I don't want this to distract from the problem that this bug report and patch are trying to mitigate (not solve!) which is that no matter what the report is and what the user might end up doing with it -- charting, downloading as *.ods or *.csv, or just viewing page by page -- the full report results (n rows of data with n unbounded) are loaded into memory on the Koha server, converted to JSON, and then returned to the user embedded in the generated HTML. For example, I ran a query that returned a single row; it yielded HTML containing the following (some whitespace, along with the bulk of the function body, removed for clarity): -------------------------------------------------------------------------------- $('#draw-chart').click(function() { var x_elements = $('select[name="x"]').val(); var y_elements = []; var groups = []; var lines = []; var options = {}; headers = [{"cell":"month"},{"cell":"year"},{"cell":"count"}]; var results; if ($('input[name="chart-include-all"]').prop('checked')) { results = [{"cells":[{"cell":"September"},{"cell":2019},{"cell":39}]}] } else { results = [{"cells":[{"cell":"September"},{"cell":"2019"},{"cell":"39"}]}] } [...] } -------------------------------------------------------------------------------- The first line that sets the _results_ variable is where the full report results appear; if the report had yielded 10,000 rows, there would be 10,000 elements in the array. And I haven't even touched on the possibility of a query like this that fails to properly JOIN tables: SELECT foo.bar, baz.qux FROM foo, baz If foo and baz each contain 10,000 rows, that's 100 million rows returned by the DB, loaded into memory, converted to JSON, and -- well, it won't get that far, because nobody is running a Koha instance with enough RAM and swap to survive this. But I would bet that a lot of Koha instances have (staff) users with the requisite permissions to write reports but not the expertise in SQL and RDBMSes that would steer them away from writing a query like this. Stepping outside the bounds of this bug report for a moment, I'll just mention some options for truly *fixing* the underlying problem that may be worth considering; these include (a) Removing the option to chart the full report results; (b) Implementing full-data charting using callbacks (AJAX or whatever) to fetch data from Koha only as it's needed; and (c) Ripping out the charting feature altogether on the principle of "do one thing well", which entails taking the position that charting is best done in a tool (Libreoffice Calc, Excel, whatever) dedicated to that task. This last one is my favorite, but I'm sure not everyone agrees! :-) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Paul, I understand the problem now. I'm not sure what's the best solution, even though I have a tendency to think we could send the data stream into a temporary file if the resultset size exceeds some fixed value, then send the file. That said, I think this issue and a proper solution deserves being discussed on our regular dev meetings on IRC. The next one is due to take place on sept 25th. [1] I'd suggest you add this problem and approach to the agenda so the dev team as a whole can discuss it. Also, adding it to the agenda in advance gives everyone time to think about it. As of the patchset itself, the only thing I wouldn't accept is that there's no fallback to a default value when reading the syspref. i.e. it could be undef and break things. [1] https://wiki.koha-community.org/wiki/Next_IRC_meetings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92992&action=edit Bug 23626: Move message to relavent chart control As it stands, this limit message makes it sounds like the chart data is limited where it clearly is not. Instead, we should show the limit on the 'use all data' checkbox. As it stands, you could actual have more results data in the chart than the system preference allows by only using the displayed results! I think this is a benefit and not a problem, since we are not refetching those data to generate the chart. Instead, we need just move the 'warning' to make it clear when the syspref limit will be used and relevant. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Video Demonstration: https://monosnap.com/file/eCK8NlXEG5hN0Z0KwHkxsuR0Hf7nq6 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Presenting an alternate patch here. We should only fetch the additional chart data when needed, using the report/svc we can get the json on demand. This also allows us to utilize the existing syspref SvcMaxReportRows Please test and let me know what you think. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #21)

With the caching on the svc you can often see confusing results when testing JSON - I think using it in the GUI could give the same problem.

I think we could add some info to GUI to make it more clear how the caching operates and why you would set it.

Is it really such an issue that we should not allow people to get "all" if they explicitly check "all"? I think at least you'd want the GUI behave differently than a more restricted web service that might be used by third parties.

It is a big issue because loading a full set of results can crash the system. Reports with a large amounts of rows/data must be loaded into memory to pass to the template in either scenario. (DON'T) Try running: SELECT * FROM items JOIN biblio_metadata USING (itemnumber) JOIN items i ON 1=1; It generates so much data it will lock the system (mine required a hard reboot). This is a silly report, but honestly large reports that are legitimate in production systems are triggering this issue. Charts are neat, but I think we can limit the amount of data they get and rely on exporting to tools meant for data analysis if large scale are needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel if we need this limit, we should not tie it to the pref and have another (yes...) and also display a tooltip or something. Otherwise this will be very hard to figure out for users. And the preset limit of 20 or something for the pref is very low. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Paul Hoffman from comment #25)

I'm worried that a rewrite of the report charting capability is going to take some time, and meanwhile our Koha server is liable to run out of memory at any time when someone runs a report that generates a lot of results.

How would you all feel about sticking to the original bug fix plan for now and reworking charting later?

Hi Paul, the maintenance releases just happened, so it will take some time to get a fix into Koha proper (until next month's bugfix release). Using reports is permission based, maybe inform your staff of the problem? Also implementing a temporary fix might be an option if you are running your own installation. Btw - I like the idea of a separate preference as I don't want to mix things with the web service preference/caching that could cause too much confusion. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #26)

(In reply to Paul Hoffman from comment #25)

...

I'm worried that a rewrite of the report charting capability is going to take some time, and meanwhile our Koha server is liable to run out of memory at any time when someone runs a report that generates a lot of results.

How would you all feel about sticking to the original bug fix plan for now and reworking charting later?

Hi Paul, the maintenance releases just happened, so it will take some time to get a fix into Koha proper (until next month's bugfix release). Using reports is permission based, maybe inform your staff of the problem? Also implementing a temporary fix might be an option if you are running your own installation.

Btw - I like the idea of a separate preference as I don't want to mix things with the web service preference/caching that could cause too much confusion.

Obsoleted my patches, this should be ready for QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Paul Hoffman <paul@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23685 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We discussed this bug during the Development Meeting and concluded that a simpler fix for now would be to add a system preference to enable/disable charting functionality entirely. In this way we would be able to skip the 'all results' call entirely whilst we work on another implementation to allow fetching of results in a more memory friendly way. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Paul Hoffman <paul@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92919|0 |1 is obsolete| | Attachment #92920|0 |1 is obsolete| | Attachment #92921|0 |1 is obsolete| | Attachment #92994|0 |1 is obsolete| | --- Comment #32 from Paul Hoffman <paul@flo.org> --- Created attachment 93204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93204&action=edit Broaden the scope of the system preference to include exported report results This patch brings the previous set of patches together, renames the system preference, and applies the limit (if set) to exported results. It will require some additional tweaking to insert a prominent note in the UI when the limit has been set. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Paul Hoffman <paul@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a system preference to |Add a system preference to |limit the number of rows of |limit the number of rows of |data used in a chart when |data used when charting or |viewing report results |exporting report results -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93406&action=edit Bug 23626: [alternate] Only fetch full chart data if requested This patchset prevents the full return of report data unless explicitly requested by the user for charting purposes Additionally the user is warned if requesting more than 1000 rows of data To test: 1 - Create a report that returns over 1000 rows of data 2 - Run the report 3 - Note you have two buttons now 'Chart data' and 'Fetch all data for chart' 4 - Click chart data 5 - Note the note that you are only charting visible data 6 - Create the chart and confirm it works 7 - Close the chart 8 - Click 'Fetch all data' 9 - Note the confirm window 10 - Click 'cancel', note there is no change 11 - Repeat and click ok 12 - Fetch all data button is gone 13 - Page to next data, note fetch all does not return 14 - Click 'Chart data' 15 - Note you now have checkbox option to use all data in report 16 - Click it 17 - Create chart 18 - Confirm it works as expected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #36 from Séverine Queune <severine.queune@bulac.fr> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 23626: <h1>Something went wrong !</h1>Applying: Limit memory consumption when exporting, too fatal: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/bug_23626.perl). error: could not build fake ancestor Patch failed at 0001 Limit memory consumption when exporting, too -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Séverine Queune from comment #36)

The sandbox you've requested is not ready. Some problems occurred applying patches from bug 23626: <h1>Something went wrong !</h1>Applying: Limit memory consumption when exporting, too fatal: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/bug_23626.perl). error: could not build fake ancestor Patch failed at 0001 Limit memory consumption when exporting, too

I obsoleted the original to allow this to apply on a sandbox -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93406|0 |1 is obsolete| | Attachment #93589|0 |1 is obsolete| | --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93720&action=edit Bug 23626: [alternate] Only fetch full chart data if requested This patchset prevents the full return of report data unless explicitly requested by the user for charting purposes Additionally the user is warned if requesting more than 1000 rows of data To test: 1 - Create a report that returns over 1000 rows of data 2 - Run the report 3 - Note you have two buttons now 'Chart data' and 'Fetch all data for chart' 4 - Click chart data 5 - Note the note that you are only charting visible data 6 - Create the chart and confirm it works 7 - Close the chart 8 - Click 'Fetch all data' 9 - Note the confirm window 10 - Click 'cancel', note there is no change 11 - Repeat and click ok 12 - Fetch all data button is gone 13 - Page to next data, note fetch all does not return 14 - Click 'Chart data' 15 - Note you now have checkbox option to use all data in report 16 - Click it 17 - Create chart 18 - Confirm it works as expected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93720|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #42 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #43 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93729&action=edit Bug 23626: [alternate] Only fetch full chart data if requested This patchset prevents the full return of report data unless explicitly requested by the user for charting purposes Additionally the user is warned if requesting more than 1000 rows of data To test: 1 - Create a report that returns over 1000 rows of data 2 - Run the report 3 - Note you have two buttons now 'Chart data' and 'Fetch all data for chart' 4 - Click chart data 5 - Note the note that you are only charting visible data 6 - Create the chart and confirm it works 7 - Close the chart 8 - Click 'Fetch all data' 9 - Note the confirm window 10 - Click 'cancel', note there is no change 11 - Repeat and click ok 12 - Fetch all data button is gone 13 - Page to next data, note fetch all does not return 14 - Click 'Chart data' 15 - Note you now have checkbox option to use all data in report 16 - Click it 17 - Create chart 18 - Confirm it works as expected Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93729|0 |1 is obsolete| | --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 93914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93914&action=edit Bug 23626: [alternate] Only fetch full chart data if requested This patchset prevents the full return of report data unless explicitly requested by the user for charting purposes Additionally the user is warned if requesting more than 1000 rows of data To test: 1 - Create a report that returns over 1000 rows of data 2 - Run the report 3 - Note you have two buttons now 'Chart data' and 'Fetch all data for chart' 4 - Click chart data 5 - Note the note that you are only charting visible data 6 - Create the chart and confirm it works 7 - Close the chart 8 - Click 'Fetch all data' 9 - Note the confirm window 10 - Click 'cancel', note there is no change 11 - Repeat and click ok 12 - Fetch all data button is gone 13 - Page to next data, note fetch all does not return 14 - Click 'Chart data' 15 - Note you now have checkbox option to use all data in report 16 - Click it 17 - Create chart 18 - Confirm it works as expected Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 93916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93916&action=edit Bug 23626: Add missing TT failure Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93981&action=edit Bug 23626: (follow-up) Fix JS when not viewing results -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Followup pushed.. I just forgot to note it here :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #51 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28470 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 [Bug 28470] Typo: Are you sure you with to chart this report? -- You are receiving this mail because: You are watching all bug changes.