http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1791 Summary: C4::Acquisition - GetBookSeller needs to be reliable on IDs Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: major Priority: P3 Component: Acquisitions AssignedTo: chris.cormack@liblime.com ReportedBy: joe.atzberger@liblime.com QAContact: koha-bugs@nongnu.org Currently GetBookSeller does SELECT * FROM aqbooksellers WHERE name LIKE ? OR id = ? regardless of what is passed in. That means if you have names beginning with numbers (like "1-2-3 Read4Fun" or "23rd Century Sci-Fi"), the sub will start returning those *also* when you think you are retrieving by ID, like GetBookSeller(1) or GetBookSeller(2). Currently this breaks basket.pl because it doesn't actually check past the first element returned, and you don't know that the "correct" result is first. I believe a librarian posted about this on list, but I wrote it off as an outlier. We'll need a function that reliably returns the bookseller based on ID. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.