[Bug 27450] New: Making password required for patron reigstration breaks patron modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Bug ID: 27450 Summary: Making password required for patron reigstration breaks patron modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org TO recreate: 1 - Set PatronSelfRegistrationBorrowerMandatoryField to require password 2 - Create or sign in as a patron on the opac 3 - Click 'Your personal details' 4 - Attempt to edit 5 - Save changes 6 - They are rejected because not all required fields are populated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, bwsdonna@gmail.com, | |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- IMO this can be best solved in Bug 13188 by separating the OPAC MandatoryField's into two sys prefs: PatronSelfModificationMandatoryField PatronSelfRegistrationBorrowerMandatoryField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115419&action=edit Bug 27450: Remove password from the mandatory fields when editing details When a patron edit their personal details at the OPAC, the password must be removed from the mandatory fields Test plan: 0 - Don't apply the patch 1 - Set PatronSelfRegistrationBorrowerMandatoryField to require password 2 - Create or sign in as a patron on the opac 3 - Click 'Your personal details' 4 - Attempt to edit 5 - Save changes => They are rejected because not all required fields are populated 6 - Apply the patch 7 - Repeat 3 to 5 => details are saved successfully 8 - Test the self registration feature and confirm that the password is required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115419|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115431&action=edit Bug 27450: Remove password from the mandatory fields when editing details When a patron edit their personal details at the OPAC, the password must be removed from the mandatory fields Test plan: 0 - Don't apply the patch 1 - Set PatronSelfRegistrationBorrowerMandatoryField to require password 2 - Create or sign in as a patron on the opac 3 - Click 'Your personal details' 4 - Attempt to edit 5 - Save changes => They are rejected because not all required fields are populated 6 - Apply the patch 7 - Repeat 3 to 5 => details are saved successfully 8 - Test the self registration feature and confirm that the password is required Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Making password required |Making password required |for patron reigstration |for patron registration |breaks patron modification |breaks patron modification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115431|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116104&action=edit Bug 27450: Remove password from the mandatory fields when editing details When a patron edit their personal details at the OPAC, the password must be removed from the mandatory fields Test plan: 0 - Don't apply the patch 1 - Set PatronSelfRegistrationBorrowerMandatoryField to require password 2 - Create or sign in as a patron on the opac 3 - Click 'Your personal details' 4 - Attempt to edit 5 - Save changes => They are rejected because not all required fields are populated 6 - Apply the patch 7 - Repeat 3 to 5 => details are saved successfully 8 - Test the self registration feature and confirm that the password is required Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #1)
IMO this can be best solved in Bug 13188 by separating the OPAC MandatoryField's into two sys prefs:
PatronSelfModificationMandatoryField PatronSelfRegistrationBorrowerMandatoryField
I believe you are right in that will be the "right" fix, but I think this will be a nice improvement for the stable branches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org