[Bug 41169] New: Cancelling order from a basket doesn't warn about removing items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41169 Bug ID: 41169 Summary: Cancelling order from a basket doesn't warn about removing items Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mikko.liimatainen@turku.fi QA Contact: testopia@bugs.koha-community.org When cancelling an order in a basket there is no warning about item deletion. This can be a problem if the item is already in circulation. If the items attached to the order can not be removed, this is given a notification as the order has been cancelled. When you are cancelling an order you get a confirmation page with this text: "Are you sure you want to cancel this order (45) Bibliographic record will not be deleted." I'd like there to be a mention that the items of this order will be deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41169 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41169 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 196989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196989&action=edit Bug 41169: Notify that items will be deleted when order is cancelled When order is cancelled, items attached to the ordered biblio are deleted. This is not mentioned in cancelorder.pl, there is only note that bibliographicrecord will not be deleted. This patch adds line "Items attached to this order will be deleted." to cancelorder.pl. To test: 1. Find an order where ordered record has items attached to it. 2. Attempt to cancel the order. 3. Yellow alert box is displayed. => Note that there is only mention that record is not deleted. 4. Apply this patch. 5. Attempt to cancel again or refresh the cancel page. => Note that there is now a mention that items will be deleted. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41169 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41169 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196989|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41169 --- Comment #2 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198903&action=edit Bug 41169: Notify that items will be deleted when order is cancelled When order is cancelled, items attached to the ordered biblio are deleted. This is not mentioned in cancelorder.pl, there is only note that bibliographicrecord will not be deleted. This patch adds line "Items attached to this order will be deleted." to cancelorder.pl. To test: 1. Find an order where ordered record has items attached to it. 2. Attempt to cancel the order. 3. Yellow alert box is displayed. => Note that there is only mention that record is not deleted. 4. Apply this patch. 5. Attempt to cancel again or refresh the cancel page. => Note that there is now a mention that items will be deleted. Sponsored-by: Koha-Suomi Oy Signed-off-by: Hannah Prince <hannah.prince@uhb.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41169 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198903|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41169 --- Comment #3 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198904&action=edit Bug 41169: Notify that items will be deleted when order is cancelled When order is cancelled, items attached to the ordered biblio are deleted. This is not mentioned in cancelorder.pl, there is only note that bibliographicrecord will not be deleted. This patch adds line "Items attached to this order will be deleted." to cancelorder.pl. To test: 1. Find an order where ordered record has items attached to it. 2. Attempt to cancel the order. 3. Yellow alert box is displayed. => Note that there is only mention that record is not deleted. 4. Apply this patch. 5. Attempt to cancel again or refresh the cancel page. => Note that there is now a mention that items will be deleted. Sponsored-by: Koha-Suomi Oy Signed-off-by: Hannah Prince <hannah.prince@uhb.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41169 Hannah Prince <hannah.prince@uhb.nhs.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hannah.prince@uhb.nhs.uk Status|Needs Signoff |Signed Off --- Comment #4 from Hannah Prince <hannah.prince@uhb.nhs.uk> --- Checked options "cancel order" and "cancel order and delete catalog record" - after the patch, both correctly displayed the message "Items attached to this order will be deleted." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41169 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41169 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When order was canceled, release notes| |there is only mention that | |biblio is not deleted but | |not one for that items | |attached to the order are | |deleted. This enhancement | |adds note "Items attached | |to this order will be | |deleted.". -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org