[Bug 3197] New: Problem editing Authority MARC Subfield Structure: no "subfield code" box
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3197 Summary: Problem editing Authority MARC Subfield Structure: no "subfield code" box Product: Koha Version: HEAD Platform: Other OS/Version: Linux - Other Status: NEW Severity: blocker Priority: P3 Component: MARC Authority data support AssignedTo: galen.charlton@liblime.com ReportedBy: repke@xs4all.nl CC: colin.campbell@ptfs-europe.com Estimated Hours: 0.0 Change sponsored?: --- Editing Authority MARC Subfield Structure is not possible. As follows, including screenshots. Might be related to bug 2917. Here is the point in the editing steps where everything is still fine after adding a new tag 109 (as test example): http://screencast.com/t/Gl2yXBzJXpD Obviously there is no Subfield list yet. After clicking "Edit subfields", things go wrong because the "subfield code" box is missing to type in the subfield (0-9, a-z) you wish to add. Here is the screenshot: http://screencast.com/t/SMSWqpqrllN If you do go on from this point and do a Save Changes anyway, Koha messes up and introduces a number of @ subfields in tag 109. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3197 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2009-05-07 14:01:26 --- Patch submitted to patches@koha.org -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3197 tipaul <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Status|RESOLVED |REOPENED Priority|P3 |PATCH-Sent Resolution|FIXED | --- Comment #2 from tipaul <paul.poulain@biblibre.com> 2009-05-07 14:09:52 --- hi Colin, thanks for the patch, but just a note : when you send a bug, don't mark it "FIXED", just change the priority to "PATCH-Sent". Then the Release Manager will test & apply it and change the resolution to FIXED. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3197 --- Comment #3 from Mason James <mason.loves.sushi@gmail.com> 2009-05-08 00:35:09 --- Created an attachment (id=788) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=788) adding patch from colin.campbell@ptfs-europe.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3197 Galen Charlton <galen.charlton@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|galen.charlton@liblime.com |colin.campbell@ptfs- | |europe.com Status|REOPENED |NEW --- Comment #4 from Galen Charlton <galen.charlton@liblime.com> 2009-05-08 12:18:57 --- Patch pushed. The bug as reported appears fixed, but there are a couple problems remaining with this form: [1] When you add a new subfield when the repeatable and/or mandatory checkboxes ticked, those two settings are not saved. To make a new subfield mandatory or repeatable, you have to edit it again. [2] There are a bug of XHTML validation warnings. Perhaps you could take a look at these, Colin? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3197 --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> 2009-05-08 14:35:10 --- Checked the marc subfields entry and the same problem with setting mandatory and repeatable on a New subfield exists there. Will need to fix both -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3197 Galen Charlton <galen.charlton@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |galen.charlton@liblime.com Severity|blocker |normal --- Comment #6 from Galen Charlton <galen.charlton@liblime.com> 2009-05-08 19:46:35 --- Changing severity to normal - this bug is not a blocker. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3197 --- Comment #7 from Galen Charlton <galen.charlton@liblime.com> 2009-06-06 19:54:30 --- Pushed patch fixing most of the XHTML validation warnings. Some remain, as well as the problem storing the repeatable and mandatory flags when entering a new subfield. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3197 --- Comment #8 from Colin Campbell <colin.campbell@ptfs-europe.com> 2009-06-23 13:33:01 --- The original bug seems to have returned in latest HEAD. Giving the code a serious going over with an eye to fixing the functionality and future maintainability -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3197 --- Comment #9 from Galen Charlton <galen.charlton@liblime.com> 2009-06-23 13:45:17 --- (In reply to comment #8)
The original bug seems to have returned in latest HEAD. Giving the code a serious going over with an eye to fixing the functionality and future maintainability
Good idea. One point for you to consider while you do this is that the admin pages for the MARC and authority frameworks do nearly exactly the same thing, just pointing to different database tables. Refactoring so that the same routine or base class handles most of the work would make it possible to kill two birds with one stone. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠liblime.com