[Bug 17356] New: Add atomic update .perl skeleton file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Bug ID: 17356 Summary: Add atomic update .perl skeleton file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55834&action=edit Bug 17356: Add atomic update .perl skeleton file To show devs how it should be written. Test plan: % cp installer/data/mysql/atomicupdate/skeleton.perl installer/data/mysql/atomicupdate/bug_XXXXX.perl % perl installer/data/mysql/updatedatabase.pl You should see: DEV atomic update: bug_xxxxx.perl Upgrade to 16.06.00.XXX done (Bug XXXXX - description) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17234 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Followed test plan. I get an error with step: % perl installer/data/mysql/updatedatabase.pl DEV atomic update: bug_XXXXX.perl Atomic update generated errors: Undefined subroutine &main::column_exists called at (eval 1045) line 5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17234 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17234 | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sorry, the dependency was wrong, you need patches from bug 17234. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55834|0 |1 is obsolete| | --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 55944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55944&action=edit Bug 17356: Add atomic update .perl skeleton file To show devs how it should be written. Test plan: % cp installer/data/mysql/atomicupdate/skeleton.perl installer/data/mysql/atomicupdate/bug_XXXXX.perl % perl installer/data/mysql/updatedatabase.pl You should see: DEV atomic update: bug_xxxxx.perl Upgrade to 16.06.00.XXX done (Bug XXXXX - description) Signed-off-by: Liz Rea <liz@catalyst.net.nz> Very good. I'll submit a patch for the readme to make the instructions better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 55945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55945&action=edit Bug 17356 - update README Test plan: Look at the README and make sure it makes sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Why not add a few lines to README and remove the skeleton.perl? Any dev would understand and is able to copy/paste. Now it executes skeleton.perl every time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #6)
Why not add a few lines to README and remove the skeleton.perl? Any dev would understand and is able to copy/paste. Now it executes skeleton.perl every time.
It should not execute the skeleton, there is a next for this filename. It seems easier to use cp than edit, copy, create a new file, paste :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 --- Comment #8 from Liz Rea <liz@catalyst.net.nz> --- I'm with Jonathan here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55944|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56444&action=edit Bug 17356: Add atomic update .perl skeleton file To show devs how it should be written. Test plan: % cp installer/data/mysql/atomicupdate/skeleton.perl installer/data/mysql/atomicupdate/bug_XXXXX.perl % perl installer/data/mysql/updatedatabase.pl You should see: DEV atomic update: bug_xxxxx.perl Upgrade to 16.06.00.XXX done (Bug XXXXX - description) Signed-off-by: Liz Rea <liz@catalyst.net.nz> Very good. I'll submit a patch for the readme to make the instructions better. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55945|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56445&action=edit Bug 17356 - update README Test plan: Look at the README and make sure it makes sense. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56446&action=edit Bug 17356: [QA Follow-up] Minor changes to skeleton.perl Due to the way the snippet is run, there is no need to add a use for C4::Installer or define $dbh (just like $DBVersion). The suggested code is commented (column_exists is not defined). Just as in updatedatabase, CheckVersion is called. The version number does not need to contain 16.06; if we do so, we should update this number each release. The XXX's work just fine. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan, Liz, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Bug 17356 depends on bug 17234, which changed state. Bug 17234 Summary: ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org