https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #93 from Maryse Simard <maryse.simard@inlibro.com> --- (In reply to Jonathan Druart from comment #88)

1. Who is the original author of this patch? Bernardo? Regarding the history I do not think so.

The author was lost when the patches were squashed. I changed it back to simith.

2. Not blocker but, when a code is not nice, better refactore and improve it than duplicate it ;) I am referring to the JS code to test if a mandatory field is filled, it would have been easier to make the function accepts an argument to check for mandatories or importants.

It's true this duplication is not very nice. I added a patch to try and reuse the current function instead of duplicating it. I followed your suggestion and used an argument to indicate whether we want a mandatory or important check. I've also set the bug back to Needs Signoff because of this change. -- You are receiving this mail because: You are watching all bug changes.