[Bug 12572] New: Use jQueryUI Accordion to display message transport types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Bug ID: 12572 Summary: Use jQueryUI Accordion to display message transport types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org When editing a notice the various message transport type settings could be grouped in a jQueryUI accordion to make the editing view a little simpler. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29680&action=edit Bug 12572 - Use jQueryUI Accordion to display message transport types The notice edit view has separate sections for each of the various message transport types. This patch groups them in a jQueryUI accordion to simplify the view. Also changed: Some label/id pairs have been changed to eliminate duplicate ids. To test, apply the patch an edit any notice under Tools -> Notices & Slips. - The message transport type fields for email, feed, phone, etc. should be correctly grouped in a collapsed accordion. The acccordion should look correct and work correctly. - Clicking the label for any form field should correctly highlight the corresponding field. - Submitting updates to the notice should work correctly for all message transport types. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 12232 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29680|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29896&action=edit [SIGNED OFF] Bug 12572 - Use jQueryUI Accordion to display message transport types The notice edit view has separate sections for each of the various message transport types. This patch groups them in a jQueryUI accordion to simplify the view. Also changed: Some label/id pairs have been changed to eliminate duplicate ids. To test, apply the patch an edit any notice under Tools -> Notices & Slips. - The message transport type fields for email, feed, phone, etc. should be correctly grouped in a collapsed accordion. The acccordion should look correct and work correctly. - Clicking the label for any form field should correctly highlight the corresponding field. - Submitting updates to the notice should work correctly for all message transport types. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as subscripted. Something small: the top border of the uncollapsed/opened section doesn't display correctly, but this is working a lot nicer than before, as now changing a message requires a lot less scrolling. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29896|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29919&action=edit Bug 12572 - Use jQueryUI Accordion to display message transport types The notice edit view has separate sections for each of the various message transport types. This patch groups them in a jQueryUI accordion to simplify the view. Also changed: Some label/id pairs have been changed to eliminate duplicate ids. To test, apply the patch an edit any notice under Tools -> Notices & Slips. - The message transport type fields for email, feed, phone, etc. should be correctly grouped in a collapsed accordion. The acccordion should look correct and work correctly. - Clicking the label for any form field should correctly highlight the corresponding field. - Submitting updates to the notice should work correctly for all message transport types. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as described. Something small: the top border of the uncollapsed/opened section doesn't display correctly, but this is working a lot nicer than before, as now changing a message requires a lot less scrolling. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29920&action=edit Bug 12572: The first tab should be open by default To avoid an extra click, the first tab (email) should be open by default. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29920|0 |1 is obsolete| | CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Comment on attachment 29920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29920 Bug 12572: The first tab should be open by default There are several uses where expanding Email doesn't make sense. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12572 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org