[Bug 38188] New: Fix populating borrowernumberslist from patron_search_selections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Bug ID: 38188 Summary: Fix populating borrowernumberslist from patron_search_selections Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: johanna.raisa@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com On patron search page populating the borrowernumberlist for batch patron modification is working randomly, the textarea is not getting the borrowernumbers everytime. In the code the textarea is populated with html() function, which usually used to get/set html elements. There should be a val() function which is used for setting values into form elements such as textarea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |johanna.raisa@koha-suomi.fi |ity.org | --- Comment #1 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 172835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172835&action=edit Bug 38188: fix populating the borrowenumberlist from patron_search_selections This patch fixes the issue of populating the borrowernumberlist from patron_search_selections. Adding borrowernumbers to the textarea randomly fails because the textarea is populated with the html() function. To test: 1) Go to the patron search 2) Select a few patrons 3) Click on the "Batch patron modification" button 4) Use browsers back button to go back to the patron search 5) Find patron_batchmod_form from browser inspector, open it. 6) Check that between the <textarea> tags, there are the borrowernumbers of the selected patrons. 7) Apply the patch 8) Repeat steps 1-6 9) Check that <textarea> tags are not populated with the borrowernumbers of the selected patrons. 10) Remove the display:none from the textarea and check that the borrowernumbers are populated there. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 172935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172935&action=edit Bug 38188: fix populating the borrowenumberlist from patron_search_selections This patch fixes the issue of populating the borrowernumberlist from patron_search_selections. Adding borrowernumbers to the textarea randomly fails because the textarea is populated with the html() function. To test: 1) Go to the patron search 2) Select a few patrons 3) Click on the "Batch patron modification" button 4) Use browsers back button to go back to the patron search 5) Find patron_batchmod_form from browser inspector, open it. 6) Check that between the <textarea> tags, there are the borrowernumbers of the selected patrons. 7) Apply the patch 8) Repeat steps 1-6 9) Check that <textarea> tags are not populated with the borrowernumbers of the selected patrons. 10) Remove the display:none from the textarea and check that the borrowernumbers are populated there. Sponsored-by: Koha-Suomi Oy Signed-off-by: Michelle Spinney <mspinney@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #172835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172935|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173506&action=edit Bug 38188: fix populating the borrowenumberlist from patron_search_selections This patch fixes the issue of populating the borrowernumberlist from patron_search_selections. Adding borrowernumbers to the textarea randomly fails because the textarea is populated with the html() function. To test: 1) Go to the patron search 2) Select a few patrons 3) Click on the "Batch patron modification" button 4) Use browsers back button to go back to the patron search 5) Find patron_batchmod_form from browser inspector, open it. 6) Check that between the <textarea> tags, there are the borrowernumbers of the selected patrons. 7) Apply the patch 8) Repeat steps 1-6 9) Check that <textarea> tags are not populated with the borrowernumbers of the selected patrons. 10) Remove the display:none from the textarea and check that the borrowernumbers are populated there. Sponsored-by: Koha-Suomi Oy Signed-off-by: Michelle Spinney <mspinney@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38188 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED CC| |jesse@bywatersolutions.com --- Comment #7 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org