[Bug 22729] New: flgAnonymized shouldn't be NULL and should be renamed anonymized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Bug ID: 22729 Summary: flgAnonymized shouldn't be NULL and should be renamed anonymized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- What the title says :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |21336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88222&action=edit Bug 22729: Adapt Koha::Patron(s) and tests This patch adapts the Koha::Patron(s) code to the column change. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88223&action=edit Bug 22729: DBIC update I add this DBIC update because I didn't manage to add the +anonymize => { is_boolean => 1 } change without the schema updating script to bark because of the non-existent column... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88224&action=edit Bug 22729: Adapt /patrons controller code to the change This patch makes the controller code aware of the flgAnonymized => anonymized change. To test: - Run $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Testing here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 88337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88337&action=edit Bug 22729: Add dbrev to rename column (incl kohastructure) Speaks for itself. Test plan: Run the dbrev. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm Running Koha/Patrons.t with perl twice no problem, but running with prove the second time results in a failure. Sql mode ? # Failed test 'With BorrowerLogs and TrackLastPatronActivity we should not spam the logs' # at t/db_dependent/Koha/Patrons.t line 1477. # got: '2' # expected: '1' t/db_dependent/Koha/Patrons.t .. 31/39 # Looks like you failed 1 test of 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This should resolve the second prove: diff --git a/Koha/Patron.pm b/Koha/Patron.pm index 6a25d717c1..90c4f38853 100644 --- a/Koha/Patron.pm +++ b/Koha/Patron.pm @@ -752,7 +752,7 @@ sub track_login { return if !$params->{force} && !C4::Context->preference('TrackLastPatronActivity'); - $self->lastseen( dt_from_string() )->store; + $self->lastseen( dt_from_string() )->SUPER::store; } =head3 move_to_deleted Obviously, there is a relation with Koha::Patron's sub store too. Safe to say that it is not directly related to this patch. We should resolve it on a new report. Opened report 22741. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88223|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 88338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88338&action=edit Bug 22729: [DO_NOT_PUSH] DBIC update I add this DBIC update because I didn't manage to add the +anonymize => { is_boolean => 1 } change without the schema updating script to bark because of the non-existent column... Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88222|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 88339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88339&action=edit Bug 22729: Adapt Koha::Patron(s) and tests This patch adapts the Koha::Patron(s) code to the column change. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88224|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 88340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88340&action=edit Bug 22729: Adapt /patrons controller code to the change This patch makes the controller code aware of the flgAnonymized => anonymized change. To test: - Run $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Marcel, I missed to upload the dbrev patch I originally wrote, and it differs from yours as I made it NOT NULL also. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88349&action=edit Bug 22729: DB update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88339|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88340|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88349|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88350&action=edit Bug 22729: DB update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88351&action=edit Bug 22729: [DO_NOT_PUSH] DBIC update I add this DBIC update because I didn't manage to add the +anonymize => { is_boolean => 1 } change without the schema updating script to bark because of the non-existent column... Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88352&action=edit Bug 22729: Adapt Koha::Patron(s) and tests This patch adapts the Koha::Patron(s) code to the column change. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88353&action=edit Bug 22729: Adapt /patrons controller code to the change This patch makes the controller code aware of the flgAnonymized => anonymized change. To test: - Run $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88350|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88692&action=edit Bug 22729: DB update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88351|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88693&action=edit Bug 22729: [DO_NOT_PUSH] DBIC update I add this DBIC update because I didn't manage to add the +anonymize => { is_boolean => 1 } change without the schema updating script to bark because of the non-existent column... Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88352|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88694&action=edit Bug 22729: Adapt Koha::Patron(s) and tests This patch adapts the Koha::Patron(s) code to the column change. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88353|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88695&action=edit Bug 22729: Adapt /patrons controller code to the change This patch makes the controller code aware of the flgAnonymized => anonymized change. To test: - Run $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88696&action=edit Bug 22729: (QA follow-up) Ensure no NULL values before setting NOT NULL Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88745&action=edit Bug 22729: (RM follow-up) Correct column in schema addition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Bug 22729 depends on bug 21336, which changed state. Bug 21336 Summary: GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug in enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org