[Bug 40960] New: Notifying holds should not print notice if no messaging preference is notified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Bug ID: 40960 Summary: Notifying holds should not print notice if no messaging preference is notified Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org In overdue_notice.pl, holds_reminder.pl, no paper notice is sent to patron if no checkbox is checked. This should be the same for notifying holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 187669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187669&action=edit Bug 40960: Fix unit tests Two unit tests have been moved/replaced to fit the desired behaviour - "patron notified when item set to waiting" -> does not fit the desired behaviour. The desired behaviour for mails/sms is already tested The desired behaviour for prints is changed to "patron not notified if no messaging preference is specified" - "patron not notified a second time (bug 11445)" -> Moved into _koha_notify_reserve tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 187670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187670&action=edit Bug 40960: Print notification only if selected type is impossible Test plan (ktd): 1 - Have henry acevedo have no mail and set messaging preference "Hold filled to sms" 2 - Have edna acosta have not messaging preference 3 - Place an hold on two books for edna acosta and henry acevedo, check in both books and select the button to fill the hold 4 - Check in notices and see that both received a notice 5 - Apply tests and run tests -> they should fail 6 - Apply patch, run rest -> they should pass 7 - Unfill both holds and fill them back. Henry should keep receiving notices while Edna should not anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 40960 Bug 40960 - Notifying holds should not print notice if no messaging preference is notified 187669 - Bug 40960: Fix unit tests 187670 - Bug 40960: Print notification only if selected type is impossible Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 40960: Fix unit tests Using index info to reconstruct a base tree... M t/db_dependent/Reserves.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Reserves.t CONFLICT (content): Merge conflict in t/db_dependent/Reserves.t error: Failed to merge in the changes. Patch failed at 0001 Bug 40960: Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187669|0 |1 is obsolete| | --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190758&action=edit Bug 40960: Fix unit tests Two unit tests have been moved/replaced to fit the desired behaviour - "patron notified when item set to waiting" -> does not fit the desired behaviour. The desired behaviour for mails/sms is already tested The desired behaviour for prints is changed to "patron not notified if no messaging preference is specified" - "patron not notified a second time (bug 11445)" -> Moved into _koha_notify_reserve tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187670|0 |1 is obsolete| | --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190759&action=edit Bug 40960: Print notification only if selected type is impossible Test plan (ktd): 1 - Have henry acevedo have no mail and set messaging preference "Hold filled to sms" 2 - Have edna acosta have not messaging preference 3 - Place an hold on two books for edna acosta and henry acevedo, check in both books and select the button to fill the hold 4 - Check in notices and see that both received a notice 5 - Apply tests and run tests -> they should fail 6 - Apply patch, run rest -> they should pass 7 - Unfill both holds and fill them back. Henry should keep receiving notices while Edna should not anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190758|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 190763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190763&action=edit Bug 40960: Fix unit tests Two unit tests have been moved/replaced to fit the desired behaviour - "patron notified when item set to waiting" -> does not fit the desired behaviour. The desired behaviour for mails/sms is already tested The desired behaviour for prints is changed to "patron not notified if no messaging preference is specified" - "patron not notified a second time (bug 11445)" -> Moved into _koha_notify_reserve tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190759|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 190764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190764&action=edit Bug 40960: Print notification only if selected type is impossible Test plan (ktd): 1 - Have henry acevedo have no mail and set messaging preference "Hold filled to sms" 2 - Have edna acosta have not messaging preference 3 - Place an hold on two books for edna acosta and henry acevedo, check in both books and select the button to fill the hold 4 - Check in notices and see that both received a notice 5 - Apply tests and run tests -> they should fail 6 - Apply patch, run rest -> they should pass 7 - Unfill both holds and fill them back. Henry should keep receiving notices while Edna should not anymore. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Enable the SMSSendDriver system preference - set to Email. 2. Running the tests: prove t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Currently, if a patron has release notes| |not set any messaging | |preferences for notifying | |them about holds filled, a | |print notice is still | |generated. | | | |With this change, a notice | |is now only generated for a | |patron if their messaging | |preferences for 'Hold | |filled' are set. This | |matches the behavor for | |overdue and hold reminder | |notices. Summary|Notifying holds should not |Only generate a notice for |print notice if no |patrons about holds filled |messaging preference is |if they have set messaging |notified |preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 --- Comment #9 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192620&action=edit Bug 40960: Fix unit tests Two unit tests have been moved/replaced to fit the desired behaviour - "patron notified when item set to waiting" -> does not fit the desired behaviour. The desired behaviour for mails/sms is already tested The desired behaviour for prints is changed to "patron not notified if no messaging preference is specified" - "patron not notified a second time (bug 11445)" -> Moved into _koha_notify_reserve tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 --- Comment #10 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192621&action=edit Bug 40960: Print notification only if selected type is impossible Test plan (ktd): 1 - Have henry acevedo have no mail and set messaging preference "Hold filled to sms" 2 - Have edna acosta have not messaging preference 3 - Place an hold on two books for edna acosta and henry acevedo, check in both books and select the button to fill the hold 4 - Check in notices and see that both received a notice 5 - Apply tests and run tests -> they should fail 6 - Apply patch, run rest -> they should pass 7 - Unfill both holds and fill them back. Henry should keep receiving notices while Edna should not anymore. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 --- Comment #12 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.03 |26.05.00,25.11.03,25.05.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.03,25.05.09 |26.05.00,25.11.03,25.05.09, released in| |24.11.15 --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.15 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.03,25.05.09, |26.05.00,25.11.03,25.05.09, released in|24.11.15 |24.11.16 --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Will instead be released in 24.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se --- Comment #16 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- This patch changes the print fallback from "send if all selected transport types fails" to "send if at least one selected transport type fails". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Jessica Andersson <jessica.andersson@alingsas.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jessica.andersson@alingsas. | |se --- Comment #18 from Jessica Andersson <jessica.andersson@alingsas.se> --- This causes problem for patrons with their messaging preferences set to receive both sms and mail and one of the transport types fails. For example when the patron does not have a mail registered but both message types are checked on their account they will receive both sms and printed notices. When using standard/pre-filled messaging preferences based on patron category this can create a large number of unwanted print notices. When a notice is sent with sms OR mail you don't want to create a print notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42809 [Bug 42809] Notification falls to print back when two messaging preferences are set but only one is valid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40960 --- Comment #19 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I created https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42809. I did not try and reproduce at this point -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org