[Bug 10232] New: Permission check for editing help files is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Bug ID: 10232 Summary: Permission check for editing help files is broken Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de CC: dpavlin@rot13.org To test: - Try editing a help file as superlibrarian, confirm you get to the editor. You might not be able to save your changes though, because of file permissions. - Try editing a help file with any of the listed permissions from the edithelp.pl file: 43 my ( $template, $loggedinuser, $cookie ) = get_template_and_user( 44 { 45 template_name => "help/edithelp.tt", 46 query => $input, 47 type => "intranet", 48 authnotrequired => 0, 49 flagsrequired => { 50 catalogue => 1, 51 circulate => 1, 52 parameters => 1, 53 borrowers => 1, 54 permissions => 1, 55 reserveforothers => 1, 56 borrow => 1, 57 reserveforself => 1, 58 editcatalogue => 1, 59 updatecharges => 1, 60 }, 61 debug => 1, 62 } 63 ); Verify it doesn't work. I think reserveforself doesn't exist in current Koha and the choice of permissions seems a bit arbitrary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is kind of a bigger problem - only superlibrarians can currently edit help files. Of course, editing help files comes with its own set of problems, as any changes made will be overwritten when updating. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- A fix could be to add a permission to edit help files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, that would probably be the cleanest option. - Right now it's limited to the superlibrarian, but the code seems like it intended something else? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6422 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11115 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org