[Bug 19062] New: Don't queue check-in/ checkout messages if patron has no e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 Bug ID: 19062 Summary: Don't queue check-in/checkout messages if patron has no e-mail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org If the patron has no e-mail address we should not queue a check-in or checkout message. If later on an e-mail address is added to the patron account all the old messages could be sent out by accident. Check out and check in messages are only interesting close to the checkout/checkin process, later on, they are just confusing to patrons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Status is supposed to be set to 'failed' and so not resent later. How could they be sent by accident? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Status|NEW |In Discussion --- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Is this resolved? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- They are still added as pending, being moved to 'failed' when the message queue is processed. Still wondering if this makes sense? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is the expected behaviour in my understanding. You could add an email later and resend the message for instance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #4)
This is the expected behaviour in my understanding. You could add an email later and resend the message for instance.
Would be good to get some more opinions here, I am actually not sure what the expected behavior is. At least we are not consistent as other messages don't create a mail entry and fall back to print and others are not generated at all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com, | |caroline.cyr-la-rose@inlibr | |o.com --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would still be interesting to figure out if we consider this a bug or a feature :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- My understanding is the same as Jonathan's. If the patron has no address, when process_message_queue runs, it puts it as "failed", and adds a comment in the db ("NO_EMAIL"). After that, it is not treated again, unless we click on the resend button, or change it manually in the db back to "pending". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am closing this WONTFIX then. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org