[Bug 29282] New: Allow items.issue and items.renewals to be shown in the bib details holdings table on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Bug ID: 29282 Summary: Allow items.issue and items.renewals to be shown in the bib details holdings table on the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Some users would like to be able to see lifetime checkouts and renewals in the holdings table on a bib detail page. It'd be cool to make those columns available, but toggled off by default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- I like the idea -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130568&action=edit Bug 29282: Add issues and renewals columns to holdings tbale on details page To test: 1 - Apply patch, restart all 2 - View a record with items in the staff client 3 - Note issues and renewals columns not shown 4 - Click the gear to edit visible columns 5 - Issues and renewals are present and hidden 6 - Click to view columns 7 - Confirm counts show, or 0 if item has not circulated/been renewed 8 - Circulate/renew an item 9 - Verify counts increase 10 - Make columns visible by default in Admin->Table settings 11 - Confirm columns show by default on details page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Teresa Rice <trice@bossierlibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trice@bossierlibrary.org --- Comment #3 from Teresa Rice <trice@bossierlibrary.org> --- We would love to see the total checkouts column from the edit items screen appear on the main bib detail page. this will allow us to immediately see how many times a materials has circulated without having additional clicks. It will aid with acquisitions. Bossier Parish Libraries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130568|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131373&action=edit Bug 29282: Add issues and renewals columns to holdings tbale on details page To test: 1 - Apply patch, restart all 2 - View a record with items in the staff client 3 - Note issues and renewals columns not shown 4 - Click the gear to edit visible columns 5 - Issues and renewals are present and hidden 6 - Click to view columns 7 - Confirm counts show, or 0 if item has not circulated/been renewed 8 - Circulate/renew an item 9 - Verify counts increase 10 - Make columns visible by default in Admin->Table settings 11 - Confirm columns show by default on details page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, this works really nicely and I like that they are hidden by default. But could you make the same changes to the otherholdings table so we keep them in sync? It's tied to the SeparateHoldings system preference that divides the items between your own and the other branches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow items.issue and |Allow items.issue and |items.renewals to be shown |items.renewals in the |in the bib details holdings |holdings table on the |table on the staff |detail page in the staff |interface |interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow items.issue and |Show items.issue and |items.renewals in the |items.renewals in the |holdings table on the |holdings table on the |detail page in the staff |detail page in the staff |interface |interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747 [Bug 30747] Column settings on otherholdings table in detail.tt doesnt work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 134981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134981&action=edit Bug 29282: (follow-up) Account for otherholdings table This patch accounts for the otherholdins table. To test: 1. Turn on SeparateHoldings 2. Find a record where the items are split by SeparateHoldings. 3. Make sure you can hide columns from the table in the Other holdings tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131373|0 |1 is obsolete| | --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 135042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135042&action=edit Bug 29282: Add issues and renewals columns to holdings tbale on details page To test: 1 - Apply patch, restart all 2 - View a record with items in the staff client 3 - Note issues and renewals columns not shown 4 - Click the gear to edit visible columns 5 - Issues and renewals are present and hidden 6 - Click to view columns 7 - Confirm counts show, or 0 if item has not circulated/been renewed 8 - Circulate/renew an item 9 - Verify counts increase 10 - Make columns visible by default in Admin->Table settings 11 - Confirm columns show by default on details page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134981|0 |1 is obsolete| | --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 135043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135043&action=edit Bug 29282: (follow-up) Account for otherholdings table This patch accounts for the otherholdins table. To test: 1. Turn on SeparateHoldings 2. Find a record where the items are split by SeparateHoldings. 3. Make sure you can hide columns from the table in the Other holdings tab. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #9 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Really nice patch - works great, thanks both! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | CC| |victor@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Is there a reason to use the classes issues_field and renewals_field for the values when the other columns don't have the _field prefix? There doesn't seem to be a name clash in the file with issues and renewals. Otherwise everything looks good for QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #10)
Is there a reason to use the classes issues_field and renewals_field for the values when the other columns don't have the _field prefix? There doesn't seem to be a name clash in the file with issues and renewals.
Otherwise everything looks good for QA.
I think those classes already has associated styles, and this was just a way to differentiate the view on this page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Nick Clemens from comment #11)
(In reply to Victor Grousset/tuxayo from comment #10)
Is there a reason to use the classes issues_field and renewals_field for the values when the other columns don't have the _field prefix? There doesn't seem to be a name clash in the file with issues and renewals.
Otherwise everything looks good for QA.
I think those classes already has associated styles, and this was just a way to differentiate the view on this page
I see a .renewals rule in staff-global.scss (though I'm struggling to find anything using the class in the templates right now) but I don't see any rules that would catch an 'issues' class. I think personally I'd like to see the consistency carried through and the _field dropped from the class names. Asking Owen for an opinion in case I've missed something obvious. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135042|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136155&action=edit Bug 29282: Add issues and renewals columns to holdings tbale on details page To test: 1 - Apply patch, restart all 2 - View a record with items in the staff client 3 - Note issues and renewals columns not shown 4 - Click the gear to edit visible columns 5 - Issues and renewals are present and hidden 6 - Click to view columns 7 - Confirm counts show, or 0 if item has not circulated/been renewed 8 - Circulate/renew an item 9 - Verify counts increase 10 - Make columns visible by default in Admin->Table settings 11 - Confirm columns show by default on details page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135043|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136156&action=edit Bug 29282: (follow-up) Account for otherholdings table This patch accounts for the otherholdins table. To test: 1. Turn on SeparateHoldings 2. Find a record where the items are split by SeparateHoldings. 3. Make sure you can hide columns from the table in the Other holdings tab. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136157&action=edit Bug 29282: (QA follow-up) Class consistency This patch updates the field classes introduced in this patchset to improve class name consistency. We remove the _field apendment and to repvent a clash we update the existing 'renewals' class elsewhere to 'renewals-info' to more clearly reflect it's content. Test plan 1) The patchset should continue to function as described in prior patches 2) Build the CSS for the staff client 3) Check the 'Checkouts' table on various screens and confirm the renewals information still displays as it always has in the table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|victor@tuxayo.net |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as described. I added a follow-up to make the classes introduced consistent with the rest of the table, but that also entailed updating an existing class elsewhere. I'll leave it to the RM to decide which way to jump here.. we can push with or without the final followup. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancment will not be backported to 22.05.x series unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org