[Bug 33499] New: Improve styling of vendor detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Bug ID: 33499 Summary: Improve styling of vendor detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com There are some inconsistencies on this page we could/should fix. * The labels of the ordering information and subscriptions section are bold, but all other labels are not. * The sections with repeating information (contacts and interfaces) could be improved for better readability. * The information takes up a lot of space. I wonder if we could reorder/regroup the information in a better way maybe? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33104 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 [Bug 33104] Add vendor interfaces -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Bug 33499 depends on bug 33104, which changed state. Bug 33104 Summary: Add vendor interfaces https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Could we also add an hyperlink for the vendor interface URI? I was expecting to be able to click on it, but it's not a link, so I have to copy/paste it in my browser. https://snipboard.io/IsYrAF.jpg -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve styling of vendor |Make interface URL |detail page |clickable on vendor details --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think some of this has been resolved since on another bug, I'll make it about the URL :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155889&action=edit Bug 33499: Make interface URL clickable on vendor details This patch adds markup around the vendor details interface URL so that it is a clickable link. To test, apply the patch and go to Acquisitions. - Search for a vendor - If you don't have a vendor with interfaces defined, edit one - Under Interfaces -> Interface details, fill out the form, including the URI field. - Add more than one interface - Save your changes and then view the vendor details page - In the Interfaces section the interfaces you defined should have clickable links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155889|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 155895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155895&action=edit Bug 33499: Make interface URL clickable on vendor details This patch adds markup around the vendor details interface URL so that it is a clickable link. To test, apply the patch and go to Acquisitions. - Search for a vendor - If you don't have a vendor with interfaces defined, edit one - Under Interfaces -> Interface details, fill out the form, including the URI field. - Add more than one interface - Save your changes and then view the vendor details page - In the Interfaces section the interfaces you defined should have clickable links. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155895|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155912&action=edit Bug 33499: Make interface URL clickable on vendor details This patch adds markup around the vendor details interface URL so that it is a clickable link. To test, apply the patch and go to Acquisitions. - Search for a vendor - If you don't have a vendor with interfaces defined, edit one - Under Interfaces -> Interface details, fill out the form, including the URI field. - Add more than one interface - Save your changes and then view the vendor details page - In the Interfaces section the interfaces you defined should have clickable links. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155913&action=edit Bug 33499: (QA follow-up) Open external links in new tab Adds target="_blank" to the vendor website and interface URLs, as we can expect them to be external sites. Also changes mark-up a little so that the URL is shown without an additional space in front, lining up with the other fields. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- acqui/supplier.tt changed with Bug 34197 not in 23.05.x So I chose to not backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff interface |Acquisitions -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org