[Bug 39379] New: The "Edit" button appears in patron search results even when you cannot edit the patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Bug ID: 39379 Summary: The "Edit" button appears in patron search results even when you cannot edit the patron Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This isn't a huge deal, but I notice that the "Edit" button appears in /cgi-bin/koha/members/members-home.pl even when you don't have edit borrower permissions. This should be an easy fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181436&action=edit Bug 39379: Sync OPAC's datatables.js with the staff interface's version This patch overwrites the OPAC version of `datatables,js` with the one for the staff interface. A block code adding links to the columns configuration page is removed as it doesn't apply to the OPAC and produces errors in the console for missing variable definitions that would be inherited from the caller context (looking for `CAN_user_parameters_manage_column_config`). To test: 1. Apply this patch 2. Find templates using `kohaTable`: $ cd koha-tmpl/opac-tmpl $ git grep kohaTable 3. Play in the UI with those pages => SUCCESS: Tables work, nothing's broken 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Attachment #181436|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181469&action=edit Bug 39379: Only display Edit patron button if enough permissions This patch adds a check for the current user permissions in order to display the 'Edit' button on the patron search screen. To test: 1. Have a patron with staff access and only `list_borrowers` permission (I picked Henry Acevedo, henry - Acevedo123) 2. Login as that user 3. Perform a patron search at http://kohadev-intra.localhost/cgi-bin/koha/members/members-home.pl => FAIL: There's an 'Edit' button 4. Click on the 'Edit' button => SUCCESS: You are told you don't have enough permissions 5. Apply this patch 6. Repeat 3 => SUCCESS: The button is not displayed 7. Login with a superlibrarian user 8. Repeat 3 => SUCCESS: You can see the button 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to David Cook from comment #0)
This isn't a huge deal, but I notice that the "Edit" button appears in /cgi-bin/koha/members/members-home.pl even when you don't have edit borrower permissions.
Good catch! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181469|0 |1 is obsolete| | --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 181554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181554&action=edit Bug 39379: Only display Edit patron button if enough permissions This patch adds a check for the current user permissions in order to display the 'Edit' button on the patron search screen. To test: 1. Have a patron with staff access and only `list_borrowers` permission (I picked Henry Acevedo, henry - Acevedo123) 2. Login as that user 3. Perform a patron search at http://kohadev-intra.localhost/cgi-bin/koha/members/members-home.pl => FAIL: There's an 'Edit' button 4. Click on the 'Edit' button => SUCCESS: You are told you don't have enough permissions 5. Apply this patch 6. Repeat 3 => SUCCESS: The button is not displayed 7. Login with a superlibrarian user 8. Repeat 3 => SUCCESS: You can see the button 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39379 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org