[Bug 40201] New: Subscription search form on the start page is missing additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Bug ID: 40201 Summary: Subscription search form on the start page is missing additional fields Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: clemens.tubach@kit.edu, michaela.sieber@kit.edu The searchable additional fields for subscriptions are not shown in the search form on the start page and it's easy to miss, that they can be searched from the "advanced search" that is reachable through the "more options" in the top search bar. It would be better if both forms would be consistent. To test: - Add at least one additional field for subscriptions that is searchable - Go to the serials module start page - Confirm the search form doesn't show the additional field - Click on the "More options" icon at the end of the top search bar - Click on the "Advanced search" link - Confirm that the additional fields display on this form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca --- Comment #1 from Koha collecto <koha@collecto.ca> --- +1 on that. Both forms should at least be consistent, but we think maybe the advanced search form is not even usefull here ? We have a "simple search" with the top search bar and the form on the stard page (serials-home.pl) could easily be considered as an advanced search form. So what if we remove completely the advanced search button and form (on serial-search.pl ) ? The aditionnal fields would simply be added in the form on the start page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de Assignee|koha-bugs@lists.koha-commun |bibliothek@th-wildau.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 --- Comment #2 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200310&action=edit Bug 40201: Add addidtional fields to subscription search on serials home This patch adds additional fields (table subscription, searchable) to the subscription search form on serials home. To test (ktd): a) create some additional fields in Admin -> Additional fields -> Serials subscriptions. Make sure the 'Searchable' checkbox is checked. b) go to serials home: More -> Serials c) Check that the form is missing the additional fields just defined. d) apply patch and call restart_all e) reload serials home and check that the search form is now extended with the additional fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200310|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 --- Comment #3 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200311&action=edit Bug 40201: Add addidtional fields to subscription search on serials home This patch adds additional fields (table subscription, searchable) to the subscription search form on serials home. To test (ktd): a) create some additional fields in Admin -> Additional fields -> Serials subscriptions. Make sure the 'Searchable' checkbox is checked. b) go to serials home: More -> Serials c) Check that the form is missing the additional fields just defined. d) apply patch and call restart_all e) reload serials home and check that the search form is now extended with the additional fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42844 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200311|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 --- Comment #4 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 200435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200435&action=edit Bug 40201: Add addidtional fields to subscription search on serials home This patch adds additional fields (table subscription, searchable) to the subscription search form on serials home. To test (ktd): a) create some additional fields in Admin -> Additional fields -> Serials subscriptions. Make sure the 'Searchable' checkbox is checked. b) go to serials home: More -> Serials c) Check that the form is missing the additional fields just defined. d) apply patch and call restart_all e) reload serials home and check that the search form is now extended with the additional fields Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Ok but the sub is still broken (depending on wantarray the returned values is different if additional fields are passed or not). I think this was the last occurrences in the code when we don't return an array, so ideally we should have a follow-up bug to remove wantarray from this sub. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200435|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200449&action=edit Bug 40201: Add addidtional fields to subscription search on serials home This patch adds additional fields (table subscription, searchable) to the subscription search form on serials home. To test (ktd): a) create some additional fields in Admin -> Additional fields -> Serials subscriptions. Make sure the 'Searchable' checkbox is checked. b) go to serials home: More -> Serials c) Check that the form is missing the additional fields just defined. d) apply patch and call restart_all e) reload serials home and check that the search form is now extended with the additional fields Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 --- Comment #7 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40201 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.04 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org