[Bug 12230] New: Set a maximum suspension days as a new issuing rule
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Bug ID: 12230 Summary: Set a maximum suspension days as a new issuing rule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com A new issuing rule will allow to set a maximum of days when suspending patrons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28169&action=edit Bug 12230: Set a maximum suspension days as a new issuing rule This patch adds a new issuing rule: maxsuspensiondays. A new column "Max. suspension duration (day)" appears in the main table of the issuing rules. If this value is filled, on returning an item, a patron won't be suspended longer than this cap. Test plan: 1/ Set "suspension in days" to 2. 2/ Check an item out to a patron and specify a due date to today - 10 days. 3/ Check the item in and verify the patron is suspended until today + 10 * 2 days. 4/ Remove the suspension. 5/ Set "Max. suspension duration" to 10. 6/ Check an item out to a patron and specify a due date to today - 10 days. 7/ Check the item in and verify the patron is suspended until today + 10 days. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28170&action=edit Bug 12230: DB changes - add issuingrules.maxsuspensiondays -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28171&action=edit Bug 12230: maxsuspensiondays should be set to NULL if not set -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- I apply against master 3.15.00.051 I see the new "Max. suspension duration (day)" column in the "Circulation and fines rules" table. But I can't set "suspension in days" to 2: after selecting "Save", it remains at 0. [No value of the raw can be changed by "Save".] So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28169|0 |1 is obsolete| | Attachment #28170|0 |1 is obsolete| | Attachment #28171|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28196&action=edit Bug 12230: Set a maximum suspension days as a new issuing rule This patch adds a new issuing rule: maxsuspensiondays. A new column "Max. suspension duration (day)" appears in the main table of the issuing rules. If this value is filled, on returning an item, a patron won't be suspended longer than this cap. Test plan: 1/ Set "suspension in days" to 2. 2/ Check an item out to a patron and specify a due date to today - 10 days. 3/ Check the item in and verify the patron is suspended until today + 10 * 2 days. 4/ Remove the suspension. 5/ Set "Max. suspension duration" to 10. 6/ Check an item out to a patron and specify a due date to today - 10 days. 7/ Check the item in and verify the patron is suspended until today + 10 days. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28197&action=edit Bug 12230: DB changes - add issuingrules.maxsuspensiondays -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28198&action=edit Bug 12230: maxsuspensiondays should be set to NULL if not set -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #4)
I see the new "Max. suspension duration (day)" column in the "Circulation and fines rules" table. But I can't set "suspension in days" to 2: after selecting "Save", it remains at 0. [No value of the raw can be changed by "Save".]
Sorry I just tested the edit. It should work now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Paola Rossi <paola.rossi@cineca.it> --- I'm sorry, but the patch doesn't work yet. In master I can "Edit" a rule, change some values, "Save" my changes. Then I see the changed rule listed in the table. In master I can add a new rule: I set "Patron category" AND/OR "Item type" values etc, and I "Save". Then I see this new rule listed in the table as a row. When I test the patch (in FF or Explorer), I can't modify or add a new rule: after "Save", I see the same rules as before. I can only "Delete" a pre-existent rule. So I can't: 1/ Set "suspension in days" to 2. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Paola Rossi <paola.rossi@cineca.it> --- Sorry! There was a problem with upgrading the version. So the status is back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Paola Rossi <paola.rossi@cineca.it> --- I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28196|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28254&action=edit Bug 12230: Set a maximum suspension days as a new issuing rule This patch adds a new issuing rule: maxsuspensiondays. A new column "Max. suspension duration (day)" appears in the main table of the issuing rules. If this value is filled, on returning an item, a patron won't be suspended longer than this cap. Test plan: 1/ Set "suspension in days" to 2. 2/ Check an item out to a patron and specify a due date to today - 10 days. 3/ Check the item in and verify the patron is suspended until today + 10 * 2 days. 4/ Remove the suspension. 5/ Set "Max. suspension duration" to 10. 6/ Check an item out to a patron and specify a due date to today - 10 days. 7/ Check the item in and verify the patron is suspended until today + 10 days. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28197|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28255&action=edit Bug 12230: DB changes - add issuingrules.maxsuspensiondays Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28198|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28256&action=edit Bug 12230: maxsuspensiondays should be set to NULL if not set Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #11)
I pass the patch to "Signed Off" status.
Thank you for testing Paola, I added your signoff to the patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28254|0 |1 is obsolete| | --- Comment #16 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 28257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28257&action=edit 1 Set a maximum suspension days as a new issuing rule -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28255|0 |1 is obsolete| | --- Comment #17 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 28258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28258&action=edit 2 DB changes - add issuingrules.maxsuspensiondays -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28256|0 |1 is obsolete| | --- Comment #18 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 28259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28259&action=edit 3 maxsuspensiondays should be set to NULL if not set -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28257|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28295&action=edit [PASSED QA] Bug 12230: Set a maximum suspension days as a new issuing rule This patch adds a new issuing rule: maxsuspensiondays. A new column "Max. suspension duration (day)" appears in the main table of the issuing rules. If this value is filled, on returning an item, a patron won't be suspended longer than this cap. Test plan: 1/ Set "suspension in days" to 2. 2/ Check an item out to a patron and specify a due date to today - 10 days. 3/ Check the item in and verify the patron is suspended until today + 10 * 2 days. 4/ Remove the suspension. 5/ Set "Max. suspension duration" to 10. 6/ Check an item out to a patron and specify a due date to today - 10 days. 7/ Check the item in and verify the patron is suspended until today + 10 days. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28258|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28296&action=edit [PASSED QA] Bug 12230: DB changes - add issuingrules.maxsuspensiondays Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28259|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28297&action=edit [PASSED QA] Bug 12230: maxsuspensiondays should be set to NULL if not set Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12406 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12230 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Set a maximum suspension |Add maximum suspension days |days as a new issuing rule |as a new issuing rule -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org