[Bug 26179] New: Remove redundant import of google font
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Bug ID: 26179 Summary: Remove redundant import of google font Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: timothy_alexis.vass@ub.lu.se QA Contact: testopia@bugs.koha-community.org Remove from koha-tmpl/opac-tmpl/bootstrap/css/bootstrap-theme-oai.css: @import url("//fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,700,400italic"); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 --- Comment #1 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 107954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107954&action=edit Removed redundant @import of google font -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |timothy_alexis.vass@ub.lu.s | |e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove redundant import of |Remove redundant import of |google font |Google font -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107954|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107969&action=edit Bug 26179: Remove redundant import of Google font Removed redundant @import of google font Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107969|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108010&action=edit Bug 26179: Remove redundant import of Google font Removed redundant @import of google font Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=26170 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't understand, can you explain what we are doing here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 --- Comment #5 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- 12:30 TimothyAlexis In bootstrap-theme.oai.css we found this and we are wondering... why? @import url("//fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,700,400italic"); 12:30 TimothyAlexis body { 12:30 font-family: "Source Sans Pro", "Helvetica Neue", Helvetica, Arial, sans-serif; 12:32 Only place I've found this stylesheet being used is in: koha-tmpl/opac-tmpl/xslt/OAI.xslt 12:48 tcohen TimothyAlexis that's because I borrowed the XSLT from DSpace and didn't notice that Simply removing the @import and "Source Sans Pro". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is your first patch pushed, Timothy, congrats! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26179 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org