https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26612 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi John, looking at that file it's only a diff and not a real patch file, missing the headers needed to be applied with our tools. Could you maybe redo it using git format-patch as described here? https://wiki.koha-community.org/wiki/Version_Control_Using_Git#Share_with_th... You also might have to set up some configuration in git to put out your name and email correctly: https://wiki.koha-community.org/wiki/Version_Control_Using_Git#Fill_some_par... Please let us know if we can help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is ready for testing, adjusting status. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26612 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111823&action=edit Bug 26612: Error during web install for it-IT translation Patch changes some of the values in the sql statement that inserts 307a unimarc row into the marc_subfield_structure which created an SQL error on installation. The fields changed are: - isurl now 0 instead of NULL, - hidden now -5 instead of NULL, - seealso empty string instead of NULL, - link empty string instead of NULL. These field values are now similar to the ones inserted for 306a or 308a. The value that caused the SQL error was using NULL for hidden (due to the NOT NULL constraint in the table definition). I have tested the install with this change and found no issues. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26612 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111823|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 111832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111832&action=edit Bug 26612: Error during web install for it-IT translation Patch changes some of the values in the sql statement that inserts 307a unimarc row into the marc_subfield_structure which created an SQL error on installation. The fields changed are: - isurl now 0 instead of NULL, - hidden now -5 instead of NULL, - seealso empty string instead of NULL, - link empty string instead of NULL. These field values are now similar to the ones inserted for 306a or 308a. The value that caused the SQL error was using NULL for hidden (due to the NOT NULL constraint in the table definition). I have tested the install with this change and found no issues. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26612 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Julian! And I believe this will be John's first patches in Koha, congrats! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26612 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26612 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.06 |20.11.00, 20.05.06, released in| |19.11.12 CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.12 -- You are receiving this mail because: You are watching all bug changes.