https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #52 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #45)

(In reply to Jonathan Druart from comment #44)

...

I think this patch is the way to go (DBrev)

However I am still struggling with something: shouldn't we allow biblionumber xor itemnumber for the different C4::CourseReserves subroutines? It does not make sense to me to pass the biblionumber when we have already the itemnumber.

Asking a QA feedback on this question.

Kyle or Tomas maybe?

I'm not opposed to that. It should be easy enough to add an exception if both are passed in. It could be re-engineered to by pk/type as well.

I adjusted the calls, followed existing return if bad params - we could add exception on another bug if needed - PQA but feel free to get a second set of eyes on follow-up -- You are receiving this mail because: You are watching all bug changes.