[Bug 29388] New: No need to decode data from misc/background_jobs_worker.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29388 Bug ID: 29388 Summary: No need to decode data from misc/background_jobs_worker.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org
From misc/background_jobs_worker.pl we are decoding the data, and pass it as an argument to ->process, this is a bit weird as we are fetching the job from ->process we could retrieve the data from there.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29388 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29388 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127211&action=edit Bug 29388: don't decode data from misc/background_jobs_worker.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29388 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Logging that here as I won't do the same mistake again. This is actually invalid, see the FIXME: 59 # FIXME This means we need to have create the DB entry before 60 # It could work in a first step, but then we will want to handle job that will be created from the message received 61 my $job = Koha::BackgroundJobs->find($args->{job_id}); We actually need a way to enqueue without creating the row in DB, sending the request to RabbitMQ would be enough. Isn't it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29388 Bug 29388 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org