[Bug 15571] New: reserveforothers permission does not remove Search to hold button from patron account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Bug ID: 15571 Summary: reserveforothers permission does not remove Search to hold button from patron account Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Deactivating the reserveforothers permission (or place_holds) effectively keeps staff from placing holds for patrons, but it should also remove the button from the patron screens (circulation.pl, moremember.pl, pay.pl, routing-lists.pl, notices.pl, statistics.pl, etc.). Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Keywords| |Academy --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Adding a check for the permission in the template should work here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Briana Greally <brianagreally@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #2 from Briana Greally <brianagreally@gmail.com> --- Created attachment 46828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46828&action=edit Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46828|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 46995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46995&action=edit [SIGNED-OFF] Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Briana, There are 2 subpermissions in the reserveforothers permission: - modify_holds_priority: Modify holds priority - place_holds: Place holds for patrons It would make more sense to test CAN_user_reserveforothers_place_holds instead. Katrin, could you confirm? It seems that we currently test CAN_user_reserveforothers in other places, but it does not look good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #5 from Briana Greally <brianagreally@gmail.com> --- Created attachment 47054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47054&action=edit Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Briana <brianagreally@gmail.com> Here is the same patch but with 'CAN_user_reserveforothers_place_holds' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Briana Greally <brianagreally@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brianagreally@gmail.com Attachment #46995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think place_holds is a good pick! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47054|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47210&action=edit Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Briana <brianagreally@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47211&action=edit Bug 15571 [QA Followup] - Remove tabs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, did you read comments 4 and 6? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think they might have accidentally uploaded the wrong patch or forgot to include the change mentioned in comment#5. Can we fix this in a little follow-up please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This subpermission is never checked actually. So either we only test for CAN_user_reserveforothers everywhere or we change all the appropriate occurrences with CAN_user_reserveforothers_place_holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, so maybe push this patch as is and then to a general clean-up separately? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- yep, agreed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org