[Bug 32257] New: Label for patron attributes misaligned on patron batch mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Bug ID: 32257 Summary: Label for patron attributes misaligned on patron batch mod Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952 On the patron batch modification tool, the label for patron attributes is misaligned. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 144210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144210&action=edit Bug 32257 : Label for Patron Attributes Misaligned Label has now been realigned to match the format of the fields above. Test Plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 144305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144305&action=edit Bug 32257: Label for patron attributes misaligned Label has now been realigned to match the format of the fields above. Test plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #144210|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #3 from David Nind <david@davidnind.com> --- Hi Matt. I probably should have marked as Failed QA, but have amended your patch as this is an easy change: 1. We normally use sentence case for field labels: I changed "Patron Attribute" to "Patron attribute". 2. Commit message title: I changed the bug title in the patch, see the development guidelines https://wiki.koha-community.org/wiki/Commit_messages#Subject_line David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the little fixes in line David.. Great to see a new dev getting welcomed to the community so nicely :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This improves the situation, but there is a remaining alignment issue: When you click on the plus, the Delete link shows far to the right. Matt, could you maybe have another look here? Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Looks like there is an empty span tag with 25% width as a placeholder for info hints for each field. I've amended the JQuery to append the Delete button before this span tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 144443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144443&action=edit Bug 32257 : Label for Patron Attributes Misaligned Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button Test Plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and Delete buttons 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144305|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Matt, everything is good looking great here except your commit title. The QA tool complains about that: * Commit title does not start with 'Bug XXXXX: ' - 32e5a26b389 Can you just change it from 'Bug 32257 ' to 'Bug 32257: ' ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Sorry not sure how I managed to add that space in! Just removed it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 144452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144452&action=edit Bug 32257: Label for Patron Attributes Misaligned Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button Test Plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and Delete buttons 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144443|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144452|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 144453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144453&action=edit Bug 32257: Label for Patron Attributes Misaligned Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button Test Plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and Delete buttons 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 144453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144453 Bug 32257: Label for Patron Attributes Misaligned Review of attachment 144453: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32257&attachment=144453) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt @@ +368,5 @@
[% END %] [% IF ( patron_attributes_codes ) %] <li class="attributes"> + <label style="width:auto;"> + <span>Patron Attribute:</span>
This is meant well, but Koha uses sentence case everywhere (it's coding guideline too) :) I'll fix in a tiny follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144453|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144489&action=edit Bug 32257: Label for patron attributes misaligned Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button Test Plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and Delete buttons 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144490&action=edit Bug 32257: Fix capitalization - Patron Attribute -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34181 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 [Bug 34181] Batch patron modification tool missing checkboxes to clear field values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 Bug 32257 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org