[Bug 11060] New: Bootstrap theme: Incorrect rendering for R2L languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Bug ID: 11060 Summary: Bootstrap theme: Incorrect rendering for R2L languages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 22014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22014&action=edit opac-bootstrap-l2r New bootstrap theme do not render correctly for R2L languages like Arabic. Good: Search bar Not good: Advance search, auth search etc, are rendered correctly but there is too much space from the right Bad: Top (black) bar, Main result box, language chooser (hidden below as noted on Bug 11057) Attached bootstrap screen capture and ccsr for comaparison. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 22015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22015&action=edit opac-ccsr-l2r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10309 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bootstrap theme: Incorrect |Bootstrap theme: Incorrect |rendering for R2L languages |rendering for right to left | |languages Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 22167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22167&action=edit Bug 11060 - Bootstrap theme: Incorrect rendering for right to left languages The right-to-left CSS copied over from the prog theme does is not relevant to the redesigned templates. This patch updates the OPAC's right-to-left CSS and adds a couple of other right-to-left CSS files to override the default Bootstrap and jQueryUI CSS. To my eye this looks correct, but I don't speak Arabic. To test you must have a set of right-to-left templates, like ar-Arab, installed for the Bootstrap theme. At this time it is necessary to download the po file to your misc/translator/po directory. Again using ar-Arab as an example: http://translate.koha-community.org/ar/314/ar-Arab-opac-bootstrap.po Install the translation. Open the OPAC, switch to that right-to-left language, and reload to refresh the changed CSS. Confirm that it looks like right-to-left is working. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22167|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 22169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22169&action=edit [SIGNED-OFF] Bug 11060 - Bootstrap theme: Incorrect rendering for right to left languages The right-to-left CSS copied over from the prog theme does is not relevant to the redesigned templates. This patch updates the OPAC's right-to-left CSS and adds a couple of other right-to-left CSS files to override the default Bootstrap and jQueryUI CSS. To my eye this looks correct, but I don't speak Arabic. To test you must have a set of right-to-left templates, like ar-Arab, installed for the Bootstrap theme. At this time it is necessary to download the po file to your misc/translator/po directory. Again using ar-Arab as an example: http://translate.koha-community.org/ar/314/ar-Arab-opac-bootstrap.po Install the translation. Open the OPAC, switch to that right-to-left language, and reload to refresh the changed CSS. Confirm that it looks like right-to-left is working. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> As far as I can tell it looks very well. No koha-qa errors 1) Downloaded arabic bootstrap PO 2) Installed ar-Arab language, enabled on OPAC 3) Tested as anonymous user and logged in one, all pages look well: cart, advanced search, user tabs. I sent an email to Karam Qubsi asking his opinion. But for me it's ok -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22169|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 22170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22170&action=edit Bug 11060 - Bootstrap theme: Incorrect rendering for right to left languages The right-to-left CSS copied over from the prog theme does is not relevant to the redesigned templates. This patch updates the OPAC's right-to-left CSS and adds a couple of other right-to-left CSS files to override the default Bootstrap and jQueryUI CSS. To my eye this looks correct, but I don't speak Arabic. To test you must have a set of right-to-left templates, like ar-Arab, installed for the Bootstrap theme. At this time it is necessary to download the po file to your misc/translator/po directory. Again using ar-Arab as an example: http://translate.koha-community.org/ar/314/ar-Arab-opac-bootstrap.po Install the translation. Open the OPAC, switch to that right-to-left language, and reload to refresh the changed CSS. Confirm that it looks like right-to-left is working. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> As far as I can tell it looks very well. No koha-qa errors 1) Downloaded arabic bootstrap PO 2) Installed ar-Arab language, enabled on OPAC 3) Tested as anonymous user and logged in one, all pages look well: cart, advanced search, user tabs. I sent an email to Karam Qubsi asking his opinion. But for me it's ok Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I was testing this at the same time as Bernardo, so I will Pass QA on it, instead of signing it off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org